[dpdk-test-report] |WARNING| pw40202 [PATCH RFC v2] vhost: new rte_vhost API proposal

checkpatch at dpdk.org checkpatch at dpdk.org
Fri May 18 11:25:29 CEST 2018


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/40202

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#208: FILE: lib/librte_vhost2/rte_vhost2.h:130:
+	/**
+	* Device is ready to operate. vdev data is now initialized. This callback

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#214: FILE: lib/librte_vhost2/rte_vhost2.h:136:
+	/**
+	* Features have changed in runtime. This is called at least once during

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#221: FILE: lib/librte_vhost2/rte_vhost2.h:143:
+	/**
+	* Start processing vq. The `vq` is guaranteed not to be modified before

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#226: FILE: lib/librte_vhost2/rte_vhost2.h:148:
+	/**
+	* Stop processing vq. It shouldn't be accessed after this callback

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#235: FILE: lib/librte_vhost2/rte_vhost2.h:157:
+	/**
+	* Custom vhost-user message handler. This is called for

WARNING:BRACES: braces {} are not necessary for single statement blocks
#341: FILE: lib/librte_vhost2/rte_vhost2.h:263:
+			if (unlikely(*len > r->guest_phys_addr + r->size - gpa)) {
+				*len = r->guest_phys_addr + r->size - gpa;
+			}

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#378: FILE: lib/librte_vhost2/rte_vhost2.h:300:
+	void *__vhost_iova_to_vva(struct virtio_net * dev, struct vhost_virtqueue * vq,

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#378: FILE: lib/librte_vhost2/rte_vhost2.h:300:
+	void *__vhost_iova_to_vva(struct virtio_net * dev, struct vhost_virtqueue * vq,

WARNING:BRACES: braces {} are not necessary for single statement blocks
#381: FILE: lib/librte_vhost2/rte_vhost2.h:303:
+	if (!vdev->iommu) {
+		return rte_vhost2_gpa_to_vva(vdev->mem, iova, len);
+	}

total: 2 errors, 7 warnings, 331 lines checked


More information about the test-report mailing list