[dpdk-test-report] |WARNING| pw52640 [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 11 06:45:43 CEST 2019
Previous message: [dpdk-test-report] |SUCCESS| [GIT MASTER] 56ba91b7bab28d77c3595a31eb5e592fdd2be040
Next message: [dpdk-test-report] |FAILURE| pw52640 [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/52640

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#52: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:269:
+^Iif (ver & (1 << VMXNET3_REV_4)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#53: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:270:
+^I^IVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_VRRS,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#54: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:271:
+^I^I^I^I       1 << VMXNET3_REV_4);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#55: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:272:
+^I^Ihw->version = VMXNET3_REV_4 + 1;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:273:
+^I} else if (ver & (1 << VMXNET3_REV_3)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#64: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:771:
+^Iif (VMXNET3_VERSION_GE_4(hw)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#65: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:772:
+^I^I/* Check for additional RSS  */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#66: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:773:
+^I^Iret = vmxnet3_v4_rss_configure(dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#67: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:774:
+^I^Iif (ret != VMXNET3_SUCCESS) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#68: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:775:
+^I^I^IPMD_INIT_LOG(ERR, "Failed to configure v4 RSS");^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:776:
+^I^I^Ireturn ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#70: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:777:
+^I^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#71: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:778:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#72: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:779:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#80: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1157:
+^Istruct vmxnet3_hw *hw = dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#81: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1158:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#89: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1168:
+^Iif (VMXNET3_VERSION_GE_4(hw)) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#90: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1169:
+^I^Idev_info->flow_type_rss_offloads |= VMXNET3_V4_RSS_MASK;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#91: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1170:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#92: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:1171:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#104: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \^M$

ERROR:SPACING: space prohibited after that open parenthesis '('
#104: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

WARNING:WHITESPACE_AFTER_LINE_CONTINUATION: Whitespace after \ makes next lines useless
#104: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#104: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:37:
+#define VMXNET3_V4_RSS_MASK ( \

ERROR:DOS_LINE_ENDINGS: DOS line endings
#105: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:38:
+^IETH_RSS_NONFRAG_IPV4_UDP | \^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#106: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:39:
+^IETH_RSS_NONFRAG_IPV6_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#107: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:40:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:110:
+#define VMXNET3_REV_4^I^I3^I^I/* Vmxnet3 Rev. 4 */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#120: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:115:
+#define VMXNET3_VERSION_GE_4(hw) ((hw)->version >= VMXNET3_REV_4 + 1)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#128: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:171:
+int vmxnet3_v4_rss_configure(struct rte_eth_dev *dev);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#129: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.h:172:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#141: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1295:
+ * Additional RSS configurations based on vmxnet v4+ APIs^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1296:
+ */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1297:
+int^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1298:
+vmxnet3_v4_rss_configure(struct rte_eth_dev *dev)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1299:
+{^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1300:
+^Istruct vmxnet3_hw *hw = dev->data->dev_private;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#147: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1301:
+^IVmxnet3_DriverShared *shared = hw->shared;^M$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_DriverShared>
#147: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1301:
+	Vmxnet3_DriverShared *shared = hw->shared;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#148: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+^IVmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;^M$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_CmdInfo>
#148: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+	Vmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;

CHECK:CAMELCASE: Avoid CamelCase: <cmdInfo>
#148: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1302:
+	Vmxnet3_CmdInfo *cmdInfo = &shared->cu.cmdInfo;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#149: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1303:
+^Istruct rte_eth_rss_conf *port_rss_conf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#150: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1304:
+^Iuint64_t rss_hf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#151: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1305:
+^Iuint32_t ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#152: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1306:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#153: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1307:
+^IPMD_INIT_FUNC_TRACE();^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#154: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1308:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#155: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1309:
+^IcmdInfo->setRSSFields = 0;^M$

CHECK:CAMELCASE: Avoid CamelCase: <setRSSFields>
#155: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1309:
+	cmdInfo->setRSSFields = 0;

ERROR:DOS_LINE_ENDINGS: DOS line endings
#156: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1310:
+        port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;^M$

ERROR:CODE_INDENT: code indent should use tabs where possible
#156: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1310:
+        port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;^M$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#156: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1310:
+        port_rss_conf = &dev->data->dev_conf.rx_adv_conf.rss_conf;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#157: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1311:
+^Irss_hf = port_rss_conf->rss_hf &^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#158: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1312:
+^I^I(VMXNET3_V4_RSS_MASK | VMXNET3_RSS_OFFLOAD_ALL);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#159: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1313:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#160: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1314:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV4_TCP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#161: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1315:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP4;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#162: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1316:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV6_TCP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#163: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1317:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_TCPIP6;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#164: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1318:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV4_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#165: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1319:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP4;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#166: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1320:
+^Iif (rss_hf & ETH_RSS_NONFRAG_IPV6_UDP)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#167: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1321:
+^I^IcmdInfo->setRSSFields |= VMXNET3_RSS_FIELDS_UDPIP6;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#168: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1322:
+^I/* TODO: ESP RSS is currently not define in rte_eth layer */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#169: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1323:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#170: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1324:
+^IVMXNET3_WRITE_BAR1_REG(hw, VMXNET3_REG_CMD,^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#171: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1325:
+^I^I^I       VMXNET3_CMD_SET_RSS_FIELDS);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#172: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1326:
+^Iret = VMXNET3_READ_BAR1_REG(hw, VMXNET3_REG_CMD);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#173: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1327:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#174: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1328:
+^Iif (ret != VMXNET3_SUCCESS) {^M$

WARNING:BRACES: braces {} are not necessary for single statement blocks
#174: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1328:
+	if (ret != VMXNET3_SUCCESS) {
+		PMD_DRV_LOG(ERR, "Set RSS fields (v4) failed: %d", ret);
+	}

ERROR:DOS_LINE_ENDINGS: DOS line endings
#175: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1329:
+^I^IPMD_DRV_LOG(ERR, "Set RSS fields (v4) failed: %d", ret);^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#176: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1330:
+^I}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#177: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1331:
+^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#178: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1332:
+^Ireturn ret;^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#179: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1333:
+}^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#180: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1334:
+^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#181: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1335:
+/*^M$

total: 72 errors, 3 warnings, 4 checks, 122 lines checked
Previous message: [dpdk-test-report] |SUCCESS| [GIT MASTER] 56ba91b7bab28d77c3595a31eb5e592fdd2be040
Next message: [dpdk-test-report] |FAILURE| pw52640 [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list