[dpdk-test-report] |WARNING| pw57864 [PATCH 20/22] net/hns3: add reset related process for hns3 PMD driver
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Aug 23 15:55:08 CEST 2019
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/57864
_coding style issues_
CHECK:BRACES: braces {} should be used on all arms of this statement
#175: FILE: drivers/net/hns3/hns3_ethdev.c:226:
+ if (event_cause == HNS3_VECTOR0_EVENT_ERR) {
[...]
+ } else if (event_cause == HNS3_VECTOR0_EVENT_RST)
[...]
+ else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#364: FILE: drivers/net/hns3/hns3_ethdev.c:4061:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#367: FILE: drivers/net/hns3/hns3_ethdev.c:4064:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#510: FILE: drivers/net/hns3/hns3_ethdev.c:4400:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#681: FILE: drivers/net/hns3/hns3_ethdev.c:4571:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#685: FILE: drivers/net/hns3/hns3_ethdev.c:4575:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#746: FILE: drivers/net/hns3/hns3_ethdev.c:4636:
+ if (hns->hw.adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1065: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1125:
+ if (rte_atomic16_read(&hw->reset.disable_cmd) == 0) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1068: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1128:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1164: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1302:
+ if (wait_data->result == HNS3_WAIT_SUCCESS)
[...]
+ else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
[...]
+ } else if (wait_data->result == HNS3_WAIT_REQUEST)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1217: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1355:
+ if (hw->adapter_state == HNS3_NIC_STARTED ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1221: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1359:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1272: FILE: drivers/net/hns3/hns3_ethdev_vf.c:1410:
+ if (hw->adapter_state == HNS3_NIC_STARTED) {
[...]
+ } else if (hw->adapter_state == HNS3_NIC_STOPPING)
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1544: FILE: drivers/net/hns3/hns3_intr.c:738:
+ if (data->check_completion) {
[...]
+ } else
[...]
CHECK:BRACES: braces {} should be used on all arms of this statement
#1550: FILE: drivers/net/hns3/hns3_intr.c:744:
+ if (msec > data->end_ms || is_reset_pending(hns) ||
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1554: FILE: drivers/net/hns3/hns3_intr.c:748:
+ } else
CHECK:BRACES: Unbalanced braces around else statement
#1556: FILE: drivers/net/hns3/hns3_intr.c:750:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1563: FILE: drivers/net/hns3/hns3_intr.c:757:
+ if (done)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1565: FILE: drivers/net/hns3/hns3_intr.c:759:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#1592: FILE: drivers/net/hns3/hns3_intr.c:786:
+ if (hw->reset.wait_data->result == HNS3_WAIT_UNKNOWN) {
[...]
+ } else if (hw->reset.wait_data->result == HNS3_WAIT_REQUEST)
[...]
total: 0 errors, 0 warnings, 20 checks, 1921 lines checked
More information about the test-report
mailing list