[dpdk-test-report] |WARNING| pw53373 [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h

checkpatch at dpdk.org checkpatch at dpdk.org
Fri May 10 18:22:31 CEST 2019


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/53373

_coding style issues_


ERROR:DOS_LINE_ENDINGS: DOS line endings
#47: FILE: app/test-pmd/cmdline.c:9986:
+^Iif (res->tcp_flags_value > RTE_NTUPLE_TCP_FLAGS_MASK) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#56: FILE: app/test-pmd/cmdline.c:10144:
+^Iif (res->tcp_flags_value > RTE_NTUPLE_TCP_FLAGS_MASK) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#69: FILE: drivers/net/e1000/igb_ethdev.c:3705:
+^Iif (filter->tcp_flags > RTE_NTUPLE_TCP_FLAGS_MASK)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#78: FILE: drivers/net/e1000/igb_ethdev.c:3785:
+^Iif (filter->filter_info.tcp_flags & RTE_NTUPLE_TCP_FLAGS_MASK) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#87: FILE: drivers/net/e1000/igb_ethdev.c:4191:
+^Iif (filter->tcp_flags > RTE_NTUPLE_TCP_FLAGS_MASK)^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#96: FILE: drivers/net/e1000/igb_ethdev.c:4321:
+^Iif (filter->filter_info.tcp_flags & RTE_NTUPLE_TCP_FLAGS_MASK) {^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#115: FILE: lib/librte_ethdev/rte_eth_ctrl.h:187:
+#define RTE_NTUPLE_TCP_FLAGS_MASK 0x3F /**< TCP flags filter can match. */^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#127: FILE: lib/librte_net/rte_tcp.h:5:
+ * Copyright(c) 2019 SmartShare Systems.^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#135: FILE: lib/librte_net/rte_tcp.h:39:
+/**^M$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#136: FILE: lib/librte_net/rte_tcp.h:40:
+ * TCP Flags^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#137: FILE: lib/librte_net/rte_tcp.h:41:
+ */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#138: FILE: lib/librte_net/rte_tcp.h:42:
+#define TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#139: FILE: lib/librte_net/rte_tcp.h:43:
+#define TCP_ECE_FLAG 0x40 /**< ECN-Echo */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#140: FILE: lib/librte_net/rte_tcp.h:44:
+#define TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#141: FILE: lib/librte_net/rte_tcp.h:45:
+#define TCP_ACK_FLAG 0x10 /**< Acknowledgment field significant */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#142: FILE: lib/librte_net/rte_tcp.h:46:
+#define TCP_PSH_FLAG 0x08 /**< Push Function */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#143: FILE: lib/librte_net/rte_tcp.h:47:
+#define TCP_RST_FLAG 0x04 /**< Reset the connection */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#144: FILE: lib/librte_net/rte_tcp.h:48:
+#define TCP_SYN_FLAG 0x02 /**< Synchronize sequence numbers */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#145: FILE: lib/librte_net/rte_tcp.h:49:
+#define TCP_FIN_FLAG 0x01 /**< No more data from sender */^M$

ERROR:DOS_LINE_ENDINGS: DOS line endings
#146: FILE: lib/librte_net/rte_tcp.h:50:
+^M$

total: 20 errors, 0 warnings, 87 lines checked


More information about the test-report mailing list