[dpdk-test-report] |WARNING| pw67443 net/nfb: check rxmac array size

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Mar 30 18:04:19 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/67443

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#74: 
The driver wrongly assumed the presence of at least one rxmac in every firmware

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: drivers/net/nfb/nfb_rxmode.c:57:
+       if (internals->max_rxmac > 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#89: FILE: drivers/net/nfb/nfb_rxmode.c:57:
+       if (internals->max_rxmac > 0)
+               nc_rxmac_read_status(internals->rxmac[0], &status);

ERROR:CODE_INDENT: code indent should use tabs where possible
#90: FILE: drivers/net/nfb/nfb_rxmode.c:58:
+               nc_rxmac_read_status(internals->rxmac[0], &status);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: drivers/net/nfb/nfb_rxmode.c:58:
+               nc_rxmac_read_status(internals->rxmac[0], &status);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#100: FILE: drivers/net/nfb/nfb_rxmode.c:107:
+       if (internals->max_rxmac > 0)$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#100: FILE: drivers/net/nfb/nfb_rxmode.c:107:
+       if (internals->max_rxmac > 0)
+               nc_rxmac_read_status(internals->rxmac[0], &status);

ERROR:CODE_INDENT: code indent should use tabs where possible
#101: FILE: drivers/net/nfb/nfb_rxmode.c:108:
+               nc_rxmac_read_status(internals->rxmac[0], &status);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#101: FILE: drivers/net/nfb/nfb_rxmode.c:108:
+               nc_rxmac_read_status(internals->rxmac[0], &status);$

total: 2 errors, 7 warnings, 0 checks, 19 lines checked


More information about the test-report mailing list