[dpdk-test-report] |WARNING| pw79621 [PATCH v2 05/56] net/txgbe: add mac type and bus lan id

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79621

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#133: FILE: drivers/net/txgbe/base/txgbe_hw.c:29:
+	if (TXGBE_PWR_LANID_SWAP == TXGBE_PWR_LANID(reg))

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#176: FILE: drivers/net/txgbe/base/txgbe_hw.c:72:
+	DEBUGFUNC("txgbe_set_mac_type
");

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#213: FILE: drivers/net/txgbe/base/txgbe_hw.c:109:
+	DEBUGOUT("txgbe_set_mac_type found mac: %d media: %d, returns: %d
",

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#397: FILE: drivers/net/txgbe/base/txgbe_type.h:136:
+	s32 (*get_bus_info)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#398: FILE: drivers/net/txgbe/base/txgbe_type.h:137:
+	void (*set_lan_id)(struct txgbe_hw *);

CHECK:SPACING: No space is necessary after a cast
#497: FILE: drivers/net/txgbe/txgbe_ethdev.c:120:
+			     (int)hw->mac.type, (int) hw->phy.type);

total: 0 errors, 5 warnings, 1 checks, 393 lines checked