[dpdk-test-report] |WARNING| pw77384 [RFC 1/3] net/virtio: move AVX based Rx and Tx code to separate file

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 11 14:10:30 CEST 2020


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77384

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <_Pragma>
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#178: FILE: drivers/net/virtio/virtio_rxtx_packed.h:52:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("GCC unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#183: FILE: drivers/net/virtio/virtio_rxtx_packed.h:57:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll 4") \
+	for (iter = val; iter < size; iter++)

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'size' may be better as '(size)' to avoid precedence issues
#188: FILE: drivers/net/virtio/virtio_rxtx_packed.h:62:
+#define virtio_for_each_try_unroll(iter, val, size) _Pragma("unroll (4)") \
+	for (iter = val; iter < size; iter++)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects?
#193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'num' may be better as '(num)' to avoid precedence issues
#193: FILE: drivers/net/virtio/virtio_rxtx_packed.h:67:
+#define virtio_for_each_try_unroll(iter, val, num) \
+	for (iter = val; iter < num; iter++)

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Joyce Kong <joyce.kong at arm.com>'

total: 3 errors, 1 warnings, 9 checks, 618 lines checked
Warning in drivers/net/virtio/virtio_rxtx_packed.c:
Using rte_panic/rte_exit


More information about the test-report mailing list