[dpdk-test-report] |WARNING| pw78709 [PATCH v3 32/60] common/sfc_efx/base: implement Rx control path for Riverhead

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78709

_coding style issues_


WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#383: FILE: drivers/common/sfc_efx/base/rhead_impl.h:323:
+	__inout		unsigned int *pushedp);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#449: FILE: drivers/common/sfc_efx/base/rhead_rx.c:23:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#453: FILE: drivers/common/sfc_efx/base/rhead_rx.c:27:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#490: FILE: drivers/common/sfc_efx/base/rhead_rx.c:64:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#494: FILE: drivers/common/sfc_efx/base/rhead_rx.c:68:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#508: FILE: drivers/common/sfc_efx/base/rhead_rx.c:82:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#512: FILE: drivers/common/sfc_efx/base/rhead_rx.c:86:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#529: FILE: drivers/common/sfc_efx/base/rhead_rx.c:103:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#533: FILE: drivers/common/sfc_efx/base/rhead_rx.c:107:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#549: FILE: drivers/common/sfc_efx/base/rhead_rx.c:123:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#553: FILE: drivers/common/sfc_efx/base/rhead_rx.c:127:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#569: FILE: drivers/common/sfc_efx/base/rhead_rx.c:143:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#573: FILE: drivers/common/sfc_efx/base/rhead_rx.c:147:
+	return (rc);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#586: FILE: drivers/common/sfc_efx/base/rhead_rx.c:160:
+	return (ENOTSUP);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#601: FILE: drivers/common/sfc_efx/base/rhead_rx.c:175:
+	return (ENOTSUP);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#624: FILE: drivers/common/sfc_efx/base/rhead_rx.c:198:
+	__inout	unsigned int *pushedp)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#640: FILE: drivers/common/sfc_efx/base/rhead_rx.c:214:
+	if ((rc = efx_mcdi_fini_rxq(enp, erp->er_index)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#643: FILE: drivers/common/sfc_efx/base/rhead_rx.c:217:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#655: FILE: drivers/common/sfc_efx/base/rhead_rx.c:229:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#714: FILE: drivers/common/sfc_efx/base/rhead_rx.c:288:
+	if ((rc = efx_mcdi_init_rxq(enp, ndescs, eep, label, index,

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#722: FILE: drivers/common/sfc_efx/base/rhead_rx.c:296:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#731: FILE: drivers/common/sfc_efx/base/rhead_rx.c:305:
+	return (rc);

total: 18 errors, 4 warnings, 589 lines checked