[dpdk-test-report] |WARNING| pw97061 [RFC 2/3] compress/mlx5: refactor queue creation in mlx5 add support to compress and regex drivers in BlueField3

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Aug 18 17:16:22 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97061

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:SPACING: space required before the open parenthesis '('
#152: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:2028:
+		if(attr->mmo) {

WARNING:LONG_LINE: line length of 112 exceeds 100 columns
#153: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:2029:
+			void *qpc_ext_and_pas_list = MLX5_ADDR_OF(create_qp_in, in, qpc_extension_and_pas_list);

WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#154: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:2030:
+			void* qpc_ext = MLX5_ADDR_OF(qpc_extension_and_pas_list, qpc_ext_and_pas_list, qpc_data_extension);

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#154: FILE: drivers/common/mlx5/mlx5_devx_cmds.c:2030:
+			void* qpc_ext = MLX5_ADDR_OF(qpc_extension_and_pas_list, qpc_ext_and_pas_list, qpc_data_extension);

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#384: FILE: drivers/compress/mlx5/mlx5_compress.c:273:
+	qp_attr.mmo = (priv->mmo_caps & (1<<1)) && (priv->mmo_caps & (1<<3)) && (priv->mmo_caps & (1<<5));

ERROR:SPACING: space required before the open parenthesis '('
#397: FILE: drivers/compress/mlx5/mlx5_compress.c:281:
+	if(ret) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#397: FILE: drivers/compress/mlx5/mlx5_compress.c:281:
+	if(ret) {
 		goto err;
 	}

ERROR:TRAILING_WHITESPACE: trailing whitespace
#443: FILE: drivers/compress/mlx5/mlx5_compress.c:843:
+^I    ^Iatt.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 || $

ERROR:CODE_INDENT: code indent should use tabs where possible
#443: FILE: drivers/compress/mlx5/mlx5_compress.c:843:
+^I    ^Iatt.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 || $

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#443: FILE: drivers/compress/mlx5/mlx5_compress.c:843:
+^I    ^Iatt.mmo_dma_sq_en == 0) && (att.mmo_compress_qp_en == 0 || $

total: 5 errors, 6 warnings, 296 lines checked


More information about the test-report mailing list