[dpdk-test-report] |WARNING| pw97171 [RFC 5/7] eth: make drivers to use new API to obtain descriptor status
checkpatch at dpdk.org
checkpatch at dpdk.org
Fri Aug 20 18:30:33 CEST 2021
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/97171
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#263: FILE: lib/ethdev/ethdev_driver.h:1824:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#263: FILE: lib/ethdev/ethdev_driver.h:1824:
+ return 0;$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#280: FILE: lib/ethdev/ethdev_driver.h:1841:
+#define _RTE_ETH_RX_DESC_DEF(fn) \
+_RTE_ETH_RX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *rxq; \
+ rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(rxq, offset); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#280: FILE: lib/ethdev/ethdev_driver.h:1841:
+#define _RTE_ETH_RX_DESC_DEF(fn) \
+_RTE_ETH_RX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *rxq; \
+ rc = _rte_eth_rx_desc_prolog(port_id, queue_id, &rxq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(rxq, offset); \
+}
ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: lib/ethdev/ethdev_driver.h:1890:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: lib/ethdev/ethdev_driver.h:1890:
+ return 0;$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#346: FILE: lib/ethdev/ethdev_driver.h:1907:
+#define _RTE_ETH_TX_DESC_DEF(fn) \
+_RTE_ETH_TX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *txq; \
+ rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(txq, offset); \
+}
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#346: FILE: lib/ethdev/ethdev_driver.h:1907:
+#define _RTE_ETH_TX_DESC_DEF(fn) \
+_RTE_ETH_TX_DESC_PROTO(fn) \
+{ \
+ int rc; \
+ void *txq; \
+ rc = _rte_eth_tx_desc_prolog(port_id, queue_id, &txq); \
+ if (rc != 0) \
+ return rc; \
+ return fn(txq, offset); \
+}
total: 4 errors, 4 warnings, 378 lines checked
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
Please only put __rte_experimental tags in headers (b/lib/ethdev/rte_ethdev.c)
More information about the test-report
mailing list