[dpdk-test-report] |WARNING| pw93915 [PATCH v8 03/10] eal/windows: translate Windows errors to errno-style errors

checkpatch at dpdk.org checkpatch at dpdk.org
Sat Jun 5 01:40:16 CEST 2021


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/93915

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#101: FILE: lib/eal/windows/rte_thread.c:25:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#104: FILE: lib/eal/windows/rte_thread.c:28:
+		return EFAULT;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#109: FILE: lib/eal/windows/rte_thread.c:33:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EACCES)
#114: FILE: lib/eal/windows/rte_thread.c:38:
+		return EACCES;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#117: FILE: lib/eal/windows/rte_thread.c:41:
+		return EEXIST;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EDEADLK)
#120: FILE: lib/eal/windows/rte_thread.c:44:
+		return EDEADLK;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOSYS)
#125: FILE: lib/eal/windows/rte_thread.c:49:
+		return ENOSYS;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#128: FILE: lib/eal/windows/rte_thread.c:52:
+	return EINVAL;

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#132: FILE: lib/eal/windows/rte_thread.c:56:
+thread_log_last_error(const char* message)

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#154: FILE: lib/eal/windows/rte_thread.c:141:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#178: FILE: lib/eal/windows/rte_thread.c:159:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#202: FILE: lib/eal/windows/rte_thread.c:178:
+		return EINVAL;

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 2 errors, 11 warnings, 155 lines checked


More information about the test-report mailing list