|WARNING| pw104190 [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/104190

_coding style issues_


WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#225: FILE: app/test-pmd/parameters.c:1547:
+		if (mbuf_mem_types[idx] == MBUF_MEM_GPU && strcmp(cur_fwd_eng->fwd_mode_name, "io") != 0) {

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#256: FILE: app/test-pmd/testpmd.c:556:
+int gpu_id = 0;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#268: FILE: app/test-pmd/testpmd.c:1121:
+			int gpu_id, uintptr_t * mp_addr)

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#312: FILE: app/test-pmd/testpmd.c:1165:
+	ret = rte_extmem_register(gpu_mem.buf_ptr, gpu_mem.buf_len, NULL, gpu_mem.buf_iova, gpu_page_size);

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#314: FILE: app/test-pmd/testpmd.c:1167:
+		rte_exit(EXIT_FAILURE, "Unable to register addr 0x%p, ret %d
", gpu_mem.buf_ptr, ret);

WARNING:LONG_LINE: line length of 128 exceeds 100 columns
#328: FILE: app/test-pmd/testpmd.c:1181:
+	rte_mp = rte_pktmbuf_pool_create_extbuf(pool_name, nb_mbuf, mb_mempool_cache, 0, mbuf_seg_size, socket_id, &gpu_mem, 1);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#329: FILE: app/test-pmd/testpmd.c:1182:
+	if (rte_mp == NULL) {
+		rte_exit(EXIT_FAILURE, "Creation of GPU mempool <%s> failed
", pool_name);
+	}

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#353: FILE: app/test-pmd/testpmd.c:1787:
 			for (j = 0; j < mbuf_data_size_n; j++)
+			{

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#365: FILE: app/test-pmd/testpmd.c:1795:
+											 nb_mbuf_per_pool,

WARNING:LONG_LINE: line length of 114 exceeds 100 columns
#366: FILE: app/test-pmd/testpmd.c:1796:
+											 socket_ids[i], j, gpu_id,

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#367: FILE: app/test-pmd/testpmd.c:1797:
+											 &(mempools_ext_ptr[j]));

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#378: FILE: app/test-pmd/testpmd.c:1808:
 		for (i = 0; i < mbuf_data_size_n; i++)
+		{

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#387: FILE: app/test-pmd/testpmd.c:1812:
+												   nb_mbuf_per_pool,

WARNING:LONG_LINE: line length of 144 exceeds 100 columns
#388: FILE: app/test-pmd/testpmd.c:1813:
+												   socket_num == UMA_NO_CONFIG ? 0 : socket_num,

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#389: FILE: app/test-pmd/testpmd.c:1814:
+												   i, gpu_id,

WARNING:LONG_LINE: line length of 123 exceeds 100 columns
#390: FILE: app/test-pmd/testpmd.c:1815:
+												   &(mempools_ext_ptr[i]));

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: eagostini <eagostini at nvidia.com>' != 'Signed-off-by: Elena Agostini <eagostini at nvidia.com>'

total: 4 errors, 13 warnings, 303 lines checked