|WARNING| pw117008 [PATCH v2 11/17] net/mlx5: add HW steering VLAN push, pop and VID modify flow actions

checkpatch at dpdk.org checkpatch at dpdk.org
Wed Sep 28 05:35:25 CEST 2022


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117008

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3024:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3024:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3024:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#861: FILE: drivers/net/mlx5/mlx5_flow_hw.c:5159:
+	if (priv->sh->config.dv_esw_en && priv->master) {

total: 0 errors, 1 warnings, 3 checks, 671 lines checked


More information about the test-report mailing list