|WARNING| pw126291 [PATCH 05/11] net/bnxt: update ULP shared session support

checkpatch at dpdk.org checkpatch at dpdk.org
Thu Apr 20 09:47:25 CEST 2023
Previous message (by thread): |SUCCESS| pw126293 [PATCH] app/dma-perf: introduce dma-perf application
Next message (by thread): |WARNING| pw126293 [PATCH] app/dma-perf: introduce dma-perf application
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/126291

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#150: FILE: drivers/net/bnxt/bnxt.h:702:
+        ((bp)->flags2 & BNXT_FLAGS2_TESTPMD_EN)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#150: FILE: drivers/net/bnxt/bnxt.h:702:
+        ((bp)->flags2 & BNXT_FLAGS2_TESTPMD_EN)$

WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'?
#329: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:16:
+#include "hsi_struct_def_dpdk.h"

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#644: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:565:
+	nb = sizeof(parms.ctrl_chan_name) - strlen(parms.ctrl_chan_name) - 1;

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#644: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:565:
+	nb = sizeof(parms.ctrl_chan_name) - strlen(parms.ctrl_chan_name) - 1;

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#659: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:575:
+			strncat(parms.ctrl_chan_name, "-tf_shared-wc_tcam", nb);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#661: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:577:
+			strncat(parms.ctrl_chan_name, "-tf_shared", nb);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#664: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:580:
+			strncat(parms.ctrl_chan_name, "-tf_shared", nb);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#672: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:588:
+				strncat(parms.ctrl_chan_name, session_pool_name, nb);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#706: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:614:
+	parms.device_type = bnxt_ulp_cntxt_convert_dev_id(ulp_dev_id);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#718: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:621:
+	rc = tf_open_session(tfp, &parms);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#1058: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:1340:
+	rc = tf_get_global_cfg(tfp, &parms);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#1067: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp.c:1353:
+	rc = tf_set_global_cfg(tfp, &parms);

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#2067: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c:496:
+	[BNXT_ULP_ACT_HID_3ede] = 481,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#2091: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c:520:
+	[BNXT_ULP_ACT_HID_4ede] = 505,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#8133: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c:6329:
+	.act_hid = BNXT_ULP_ACT_HID_3ede,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#8513: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_act.c:6651:
+	.act_hid = BNXT_ULP_ACT_HID_4ede,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#10759: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c:361:
+	[BNXT_ULP_CLASS_HID_0daa] = 345,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#12080: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c:1682:
+	[BNXT_ULP_CLASS_HID_c1daa] = 1666,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#15423: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c:8185:
+	.class_hid = BNXT_ULP_CLASS_HID_0daa,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#51355: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_class.c:38322:
+	.class_hid = BNXT_ULP_CLASS_HID_c1daa,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#56373: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:1764:
+	BNXT_ULP_CLASS_HID_0daa = 0x0daa,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#56373: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:1764:
+	BNXT_ULP_CLASS_HID_0daa = 0x0daa,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#57694: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3085:
+	BNXT_ULP_CLASS_HID_c1daa = 0xc1daa,

WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#57694: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3085:
+	BNXT_ULP_CLASS_HID_c1daa = 0xc1daa,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#58433: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3809:
+	BNXT_ULP_ACT_HID_3ede = 0x3ede,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#58433: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3809:
+	BNXT_ULP_ACT_HID_3ede = 0x3ede,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#58532: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3833:
+	BNXT_ULP_ACT_HID_4ede = 0x4ede,

WARNING:TYPO_SPELLING: 'ede' may be misspelled - perhaps 'edge'?
#58532: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_enum.h:3833:
+	BNXT_ULP_ACT_HID_4ede = 0x4ede,

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#83165: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_act.c:3693:
+	ULP_THOR_SYM_DECAP_FUNC_THRU_TUN},

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#83319: FILE: drivers/net/bnxt/tf_ulp/generic_templates/ulp_template_db_thor_act.c:3847:
+	ULP_THOR_SYM_DECAP_FUNC_THRU_TUN},

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107837: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:738:
+		if (parms->app_priority)

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107838: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:739:
+			*priority = parms->app_priority;

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107850: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:830:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107859: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:868:
+		ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107868: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:915:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107877: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:965:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107886: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1697:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107895: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1745:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107904: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1793:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107913: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1861:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107922: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2041:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107940: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2219:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107949: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2260:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107976: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2438:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107985: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2652:
+			tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#107996: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2688:
+	ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108005: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2738:
+	tfp = bnxt_ulp_cntxt_tfp_get(parms->ulp_ctx, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108014: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3030:
+		ulp_flow_db_shared_session_set(&fid_parms, tbl->session_type);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108191: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3196:
+			result = ULP_COMP_FLD_IDX_RD(parms, operand);

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#108195: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3199:
+				    "comp field out of bounds %" PRIu64 "
",

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108203: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3206:
+			result = !ULP_COMP_FLD_IDX_RD(parms, operand);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108215: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3216:
+			result = ULP_BITMAP_ISSET(parms->act_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108228: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3227:
+			result = !ULP_BITMAP_ISSET(parms->act_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108241: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3238:
+			result = ULP_BITMAP_ISSET(parms->hdr_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108254: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3249:
+			result = !ULP_BITMAP_ISSET(parms->hdr_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108274: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3266:
+		result = ULP_INDEX_BITMAP_GET(parms->fld_bitmap->bits, bit);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108286: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3276:
+		result = !ULP_INDEX_BITMAP_GET(parms->fld_bitmap->bits, bit);

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108311: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3296:
+		result = parms->flow_pattern_id == operand;

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108315: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3299:
+		result = parms->act_pattern_id == operand;

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108336: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3317:
+			result = ULP_BITMAP_ISSET(parms->enc_hdr_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108349: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3328:
+			result = !ULP_BITMAP_ISSET(parms->enc_hdr_bitmap->bits,

WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'?
#108374: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3352:
+		tmp = parms->act_prop->act_details[operand];

ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Randy Schacher <stuart.schacher at broadcom.com>'

total: 2 errors, 61 warnings, 1 checks, 106755 lines checked
Previous message (by thread): |SUCCESS| pw126293 [PATCH] app/dma-perf: introduce dma-perf application
Next message (by thread): |WARNING| pw126293 [PATCH] app/dma-perf: introduce dma-perf application
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list