|WARNING| pw134976 [PATCH v6] gro: fix reordering of packets in GRO layer

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Dec 8 18:54:37 CET 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/134976

_coding style issues_


WARNING:TYPO_SPELLING: 'beloging' may be misspelled - perhaps 'belonging'?
#86: 
beloging to the same flow but not handled.

WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#91: 
Co-authored-by: Kumara Parameshwaran <krathinavel at microsoft.com>

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#147: FILE: lib/gro/gro_tcp.h:195:
+	merged_tcp_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_tcp_hdr *, pkt->l2_len + pkt->l3_len);

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#215: FILE: lib/gro/gro_tcp4.c:206:
+				delete_tcp_item(tbl->items, item_idx, &tbl->item_num, INVALID_ARRAY_INDEX);

WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns
#231: FILE: lib/gro/gro_tcp4.c:215:
+		 * Any packet with additional flags like PSH,FIN should be processed and flushed immediately.

WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#232: FILE: lib/gro/gro_tcp4.c:216:
+		 * Hence marking the start time to 0, so that the packets will be flushed immediately in timer

WARNING:BRACES: braces {} are not necessary for single statement blocks
#236: FILE: lib/gro/gro_tcp4.c:220:
+			if (tcp_hdr->tcp_flags != RTE_TCP_ACK_FLAG) {
+				tbl->items[item_start_idx].start_time = 0;
+			}

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#239: FILE: lib/gro/gro_tcp4.c:223:
+			return process_tcp_item(pkt, tcp_hdr, tcp_dl, tbl->items, tbl->flows[i].start_index,

total: 0 errors, 8 warnings, 108 lines checked


More information about the test-report mailing list