|WARNING| pw135006 [PATCH 2/2] net/hns3: use stdatomic API

checkpatch at dpdk.org checkpatch at dpdk.org
Mon Dec 11 08:44:39 CET 2023
Previous message (by thread): |WARNING| pw135005-135006 [PATCH 1/2] eal: fix constraints on stdatomic API
Next message (by thread): |WARNING| pw135005 [PATCH 1/2] eal: fix constraints on stdatomic API
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/135006

_coding style issues_


CHECK:SPACING: No space is necessary after a cast
#84: FILE: drivers/net/hns3/hns3_cmd.c:47:
+	static RTE_ATOMIC(uint64_t) hns3_dma_memzone_id;

CHECK:SPACING: spaces preferred around that '*' (ctx:VxW)
#179: FILE: drivers/net/hns3/hns3_ethdev.c:102:
+						 RTE_ATOMIC(uint64_t)* levels);
 						                     ^

CHECK:SPACING: spaces preferred around that '*' (ctx:VxW)
#278: FILE: drivers/net/hns3/hns3_ethdev.c:5689:
+hns3_get_reset_level(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t)* levels)
                                                                    ^

CHECK:SPACING: No space is necessary after a cast
#347: FILE: drivers/net/hns3/hns3_ethdev.h:402:
+	RTE_ATOMIC(uint16_t) schedule;

CHECK:SPACING: No space is necessary after a cast
#350: FILE: drivers/net/hns3/hns3_ethdev.h:404:
+	RTE_ATOMIC(uint16_t) resetting;

CHECK:SPACING: No space is necessary after a cast
#353: FILE: drivers/net/hns3/hns3_ethdev.h:406:
+	RTE_ATOMIC(uint16_t) disable_cmd;

CHECK:SPACING: No space is necessary after a cast
#358: FILE: drivers/net/hns3/hns3_ethdev.h:410:
+	RTE_ATOMIC(uint64_t) pending;

CHECK:SPACING: No space is necessary after a cast
#361: FILE: drivers/net/hns3/hns3_ethdev.h:412:
+	RTE_ATOMIC(uint64_t) request;

CHECK:SPACING: No space is necessary after a cast
#370: FILE: drivers/net/hns3/hns3_ethdev.h:500:
+	RTE_ATOMIC(unsigned int) secondary_cnt; /* Number of secondary processes init'd. */

CHECK:SPACING: No space is necessary after a cast
#379: FILE: drivers/net/hns3/hns3_ethdev.h:845:
+	RTE_ATOMIC(uint16_t) pf_push_lsc_cap;

CHECK:SPACING: No space is necessary after a cast
#388: FILE: drivers/net/hns3/hns3_ethdev.h:854:
+	RTE_ATOMIC(uint16_t) poll_job_started; /* whether poll job is started */

CHECK:SPACING: No space is necessary after a cast
#397: FILE: drivers/net/hns3/hns3_ethdev.h:998:
+hns3_atomic_test_bit(unsigned int nr, RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#397: FILE: drivers/net/hns3/hns3_ethdev.h:998:
+hns3_atomic_test_bit(unsigned int nr, RTE_ATOMIC(uint64_t) *addr)
                                                            ^

CHECK:SPACING: No space is necessary after a cast
#409: FILE: drivers/net/hns3/hns3_ethdev.h:1008:
+hns3_atomic_set_bit(unsigned int nr, RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#409: FILE: drivers/net/hns3/hns3_ethdev.h:1008:
+hns3_atomic_set_bit(unsigned int nr, RTE_ATOMIC(uint64_t) *addr)
                                                           ^

CHECK:SPACING: No space is necessary after a cast
#418: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#418: FILE: drivers/net/hns3/hns3_ethdev.h:1015:
+hns3_atomic_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#427: FILE: drivers/net/hns3/hns3_ethdev.h:1022:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#427: FILE: drivers/net/hns3/hns3_ethdev.h:1022:
+hns3_test_and_clear_bit(unsigned int nr, volatile RTE_ATOMIC(uint64_t) *addr)
                                                                        ^

CHECK:SPACING: No space is necessary after a cast
#446: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#446: FILE: drivers/net/hns3/hns3_ethdev_vf.c:40:
+						    RTE_ATOMIC(uint64_t) *levels);
 						                         ^

CHECK:SPACING: No space is necessary after a cast
#635: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2038:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#635: FILE: drivers/net/hns3/hns3_ethdev_vf.c:2038:
+hns3vf_get_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#683: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#683: FILE: drivers/net/hns3/hns3_intr.c:2036:
+		     int num, RTE_ATOMIC(uint64_t) *levels,
 		                                   ^

CHECK:SPACING: No space is necessary after a cast
#692: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#692: FILE: drivers/net/hns3/hns3_intr.c:2107:
+hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                       ^

CHECK:SPACING: No space is necessary after a cast
#701: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#701: FILE: drivers/net/hns3/hns3_intr.c:2154:
+hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels)
                                                                      ^

CHECK:SPACING: No space is necessary after a cast
#769: FILE: drivers/net/hns3/hns3_intr.c:2541:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#769: FILE: drivers/net/hns3/hns3_intr.c:2541:
+hns3_clear_reset_level(struct hns3_hw *hw, RTE_ATOMIC(uint64_t) *levels)
                                                                 ^

CHECK:SPACING: No space is necessary after a cast
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                            ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#823: FILE: drivers/net/hns3/hns3_intr.h:174:
+void hns3_handle_msix_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: No space is necessary after a cast
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);
                                                                           ^

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint64_t' should also have an identifier name
#824: FILE: drivers/net/hns3/hns3_intr.h:175:
+void hns3_handle_ras_error(struct hns3_adapter *hns, RTE_ATOMIC(uint64_t) *levels);

total: 0 errors, 2 warnings, 35 checks, 777 lines checked
Previous message (by thread): |WARNING| pw135005-135006 [PATCH 1/2] eal: fix constraints on stdatomic API
Next message (by thread): |WARNING| pw135005 [PATCH 1/2] eal: fix constraints on stdatomic API
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the test-report mailing list