|WARNING| pw135005-135006 [PATCH] [2/2] net/hns3: use stdatomic API

dpdklab at iol.unh.edu dpdklab at iol.unh.edu
Mon Dec 11 10:18:46 CET 2023


Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/135005

_apply patch failure_

Submitter: Jie Hai <haijie1 at huawei.com>
Date: Monday, December 11 2023 07:39:04 
Applied on: CommitID:f2d5afbb2c05d7647da7ea914887c52115652651
Apply patch set 135005-135006 failed:

Checking patch drivers/net/hns3/hns3_cmd.c...
Checking patch drivers/net/hns3/hns3_dcb.c...
Checking patch drivers/net/hns3/hns3_ethdev.c...
error: while searching for:

	last_req = hns3_get_reset_level(hns, &hw->reset.pending);
	if (last_req == HNS3_NONE_RESET || last_req < new_req) {
		__atomic_store_n(&hw->reset.disable_cmd, 1, __ATOMIC_RELAXED);
		hns3_schedule_delayed_reset(hns);
		hns3_warn(hw, "High level reset detected, delay do reset");
		return true;

error: patch failed: drivers/net/hns3/hns3_ethdev.c:5577
Hunk #11 succeeded at 5695 (offset 9 lines).
Hunk #12 succeeded at 5755 (offset 9 lines).
Hunk #13 succeeded at 5811 (offset 9 lines).
Hunk #14 succeeded at 5933 (offset 9 lines).
Hunk #15 succeeded at 5945 (offset 9 lines).
Hunk #16 succeeded at 6596 (offset 9 lines).
Checking patch drivers/net/hns3/hns3_ethdev.h...
Checking patch drivers/net/hns3/hns3_ethdev_vf.c...
Hunk #2 succeeded at 478 (offset -6 lines).
Hunk #3 succeeded at 559 (offset -6 lines).
Hunk #4 succeeded at 633 (offset -1 lines).
error: while searching for:
	struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
	struct hns3_vf_to_pf_msg req;

	__atomic_store_n(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN,
			 __ATOMIC_RELEASE);

	hns3vf_mbx_setup(&req, HNS3_MBX_GET_LINK_STATUS, 0);
	(void)hns3vf_mbx_send(hw, &req, false, NULL, 0);

error: patch failed: drivers/net/hns3/hns3_ethdev_vf.c:650
error: while searching for:
		 * mailbox from PF driver to get this capability.
		 */
		hns3vf_handle_mbx_msg(hw);
		if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=
			HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
			break;
		remain_ms--;

error: patch failed: drivers/net/hns3/hns3_ethdev_vf.c:666
Hunk #7 succeeded at 675 (offset -3 lines).
Hunk #8 succeeded at 912 (offset -9 lines).
Hunk #9 succeeded at 948 (offset -9 lines).
Hunk #10 succeeded at 987 (offset -8 lines).
Hunk #11 succeeded at 1047 (offset -13 lines).
Hunk #12 succeeded at 1238 (offset -16 lines).
Hunk #13 succeeded at 1250 (offset -16 lines).
Hunk #14 succeeded at 1484 (offset -18 lines).
Hunk #15 succeeded at 1512 (offset -18 lines).
Hunk #16 succeeded at 1627 (offset -18 lines).
error: while searching for:

	last_req = hns3vf_get_reset_level(hw, &hw->reset.pending);
	if (last_req == HNS3_NONE_RESET || last_req < new_req) {
		__atomic_store_n(&hw->reset.disable_cmd, 1, __ATOMIC_RELAXED);
		hns3_schedule_delayed_reset(hns);
		hns3_warn(hw, "High level reset detected, delay do reset");
		return true;

error: patch failed: drivers/net/hns3/hns3_ethdev_vf.c:1773
Hunk #18 succeeded at 1811 (offset -39 lines).
Hunk #19 succeeded at 1853 (offset -39 lines).
Hunk #20 succeeded at 1996 (offset -39 lines).
Hunk #21 succeeded at 2036 (offset -39 lines).
Hunk #22 succeeded at 2048 (offset -39 lines).
Hunk #23 succeeded at 2243 (offset -39 lines).
Checking patch drivers/net/hns3/hns3_intr.c...
Checking patch drivers/net/hns3/hns3_intr.h...
Checking patch drivers/net/hns3/hns3_mbx.c...
Hunk #1 succeeded at 59 (offset -6 lines).
error: while searching for:
	rte_spinlock_lock(&hw->cmq.crq.lock);

	while (!hns3_cmd_crq_empty(hw)) {
		if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED)) {
			rte_spinlock_unlock(&hw->cmq.crq.lock);
			return;
		}

error: patch failed: drivers/net/hns3/hns3_mbx.c:382
Hunk #3 succeeded at 426 (offset -33 lines).
Checking patch drivers/net/hns3/hns3_mp.c...
Checking patch drivers/net/hns3/hns3_rxtx.c...
Hunk #1 succeeded at 4465 (offset 2 lines).
Hunk #2 succeeded at 4532 (offset 2 lines).
Hunk #3 succeeded at 4589 (offset 2 lines).
Hunk #4 succeeded at 4619 (offset 2 lines).
Hunk #5 succeeded at 4653 (offset 2 lines).
Checking patch drivers/net/hns3/hns3_tm.c...
Applied patch drivers/net/hns3/hns3_cmd.c cleanly.
Applied patch drivers/net/hns3/hns3_dcb.c cleanly.
Applying patch drivers/net/hns3/hns3_ethdev.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Rejected hunk #10.
Hunk #11 applied cleanly.
Hunk #12 applied cleanly.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Applied patch drivers/net/hns3/hns3_ethdev.h cleanly.
Applying patch drivers/net/hns3/hns3_ethdev_vf.c with 3 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Rejected hunk #5.
Rejected hunk #6.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
Hunk #12 applied cleanly.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Rejected hunk #17.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Hunk #20 applied cleanly.
Hunk #21 applied cleanly.
Hunk #22 applied cleanly.
Hunk #23 applied cleanly.
Applied patch drivers/net/hns3/hns3_intr.c cleanly.
Applied patch drivers/net/hns3/hns3_intr.h cleanly.
Applying patch drivers/net/hns3/hns3_mbx.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Applied patch drivers/net/hns3/hns3_mp.c cleanly.
Applied patch drivers/net/hns3/hns3_rxtx.c cleanly.
Applied patch drivers/net/hns3/hns3_tm.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c	(rejected hunks)
@@ -5577,7 +5585,8 @@ hns3_is_reset_pending(struct hns3_adapter *hns)
 
 	last_req = hns3_get_reset_level(hns, &hw->reset.pending);
 	if (last_req == HNS3_NONE_RESET || last_req < new_req) {
-		__atomic_store_n(&hw->reset.disable_cmd, 1, __ATOMIC_RELAXED);
+		rte_atomic_store_explicit(&hw->reset.disable_cmd, 1,
+					  rte_memory_order_relaxed);
 		hns3_schedule_delayed_reset(hns);
 		hns3_warn(hw, "High level reset detected, delay do reset");
 		return true;
diff a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c	(rejected hunks)
@@ -650,8 +650,8 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
 	struct hns3_vf *vf = HNS3_DEV_HW_TO_VF(hw);
 	struct hns3_vf_to_pf_msg req;
 
-	__atomic_store_n(&vf->pf_push_lsc_cap, HNS3_PF_PUSH_LSC_CAP_UNKNOWN,
-			 __ATOMIC_RELEASE);
+	rte_atomic_store_explicit(&vf->pf_push_lsc_cap,
+			HNS3_PF_PUSH_LSC_CAP_UNKNOWN, rte_memory_order_release);
 
 	hns3vf_mbx_setup(&req, HNS3_MBX_GET_LINK_STATUS, 0);
 	(void)hns3vf_mbx_send(hw, &req, false, NULL, 0);
@@ -666,7 +666,8 @@ hns3vf_get_push_lsc_cap(struct hns3_hw *hw)
 		 * mailbox from PF driver to get this capability.
 		 */
 		hns3vf_handle_mbx_msg(hw);
-		if (__atomic_load_n(&vf->pf_push_lsc_cap, __ATOMIC_ACQUIRE) !=
+		if (rte_atomic_load_explicit(&vf->pf_push_lsc_cap,
+					     rte_memory_order_acquire) !=
 			HNS3_PF_PUSH_LSC_CAP_UNKNOWN)
 			break;
 		remain_ms--;
@@ -1773,7 +1775,8 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)
 
 	last_req = hns3vf_get_reset_level(hw, &hw->reset.pending);
 	if (last_req == HNS3_NONE_RESET || last_req < new_req) {
-		__atomic_store_n(&hw->reset.disable_cmd, 1, __ATOMIC_RELAXED);
+		rte_atomic_store_explicit(&hw->reset.disable_cmd, 1,
+					 rte_memory_order_relaxed);
 		hns3_schedule_delayed_reset(hns);
 		hns3_warn(hw, "High level reset detected, delay do reset");
 		return true;
diff a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c	(rejected hunks)
@@ -382,7 +383,8 @@ hns3pf_handle_mbx_msg(struct hns3_hw *hw)
 	rte_spinlock_lock(&hw->cmq.crq.lock);
 
 	while (!hns3_cmd_crq_empty(hw)) {
-		if (__atomic_load_n(&hw->reset.disable_cmd, __ATOMIC_RELAXED)) {
+		if (rte_atomic_load_explicit(&hw->reset.disable_cmd,
+					     rte_memory_order_relaxed)) {
 			rte_spinlock_unlock(&hw->cmq.crq.lock);
 			return;
 		}

https://lab.dpdk.org/results/dashboard/patchsets/28580/

UNH-IOL DPDK Community Lab


More information about the test-report mailing list