|WARNING| pw123215 [PATCH v6 2/9] vhost: simplify need reply handling

checkpatch at dpdk.org checkpatch at dpdk.org
Tue Feb 7 11:46:05 CET 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/123215

_coding style issues_


WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#72: 
Dedicate send_vhost_slave_message() helper to the case when no reply is

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#75: 
Add a send_vhost_slave_message_process_reply() helper for the opposite.

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#76: 
This new helper merges both send_vhost_slave_message() and the code

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#77: 
previously in process_slave_message_reply().

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#78: 
The slave_req_lock lock is then only handled in this helper which will

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#98: FILE: lib/vhost/vhost_user.c:2881:
+send_vhost_slave_message(struct virtio_net *dev, struct vhu_msg_context *ctx)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#100: FILE: lib/vhost/vhost_user.c:2883:
+	return send_vhost_message(dev, dev->slave_req_fd, ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#104: FILE: lib/vhost/vhost_user.c:2887:
+send_vhost_slave_message_process_reply(struct virtio_net *dev, struct vhu_msg_context *ctx)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#111: FILE: lib/vhost/vhost_user.c:2892:
+	rte_spinlock_lock(&dev->slave_req_lock);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#112: FILE: lib/vhost/vhost_user.c:2893:
+	ret = send_vhost_slave_message(dev, ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#121: FILE: lib/vhost/vhost_user.c:2899:
+	ret = read_vhost_message(dev, dev->slave_req_fd, &msg_reply);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#125: FILE: lib/vhost/vhost_user.c:2903:
+				"vhost read slave message reply failed
");

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#132: FILE: lib/vhost/vhost_user.c:2910:
+	if (msg_reply.msg.request.slave != ctx->msg.request.slave) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#132: FILE: lib/vhost/vhost_user.c:2910:
+	if (msg_reply.msg.request.slave != ctx->msg.request.slave) {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#135: FILE: lib/vhost/vhost_user.c:2913:
+			msg_reply.msg.request.slave, ctx->msg.request.slave);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#135: FILE: lib/vhost/vhost_user.c:2913:
+			msg_reply.msg.request.slave, ctx->msg.request.slave);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#142: FILE: lib/vhost/vhost_user.c:2920:
+	rte_spinlock_unlock(&dev->slave_req_lock);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#196: FILE: lib/vhost/vhost_user.c:3273:
+rte_vhost_slave_config_change(int vid, bool need_reply)

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#231: FILE: lib/vhost/vhost_user.c:3290:
+		ret = send_vhost_slave_message(dev, &ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#234: FILE: lib/vhost/vhost_user.c:3293:
+		ret = send_vhost_slave_message_process_reply(dev, &ctx);

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#249: FILE: lib/vhost/vhost_user.c:3327:
+	ret = send_vhost_slave_message_process_reply(dev, &ctx);

total: 0 errors, 21 warnings, 163 lines checked


More information about the test-report mailing list