|WARNING| pw128941 [PATCH v7 2/4] common/sfc_efx/base: add API to get installed filters count

[checkpatch at dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/128941

_coding style issues_


ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#90: FILE: drivers/common/sfc_efx/base/ef10_filter.c:2133:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#145: FILE: drivers/common/sfc_efx/base/efx_filter.c:315:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#164: FILE: drivers/common/sfc_efx/base/efx_filter.c:334:
+	if ((rc = enp->en_efop->efo_get_count(enp, count)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#167: FILE: drivers/common/sfc_efx/base/efx_filter.c:337:
+	return (0);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'efx_nic_t *' should also have an identifier name
#185: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'uint32_t *' should also have an identifier name
#185: FILE: drivers/common/sfc_efx/base/efx_impl.h:291:
+	efx_rc_t	(*efo_get_count)(efx_nic_t *, uint32_t *);

total: 4 errors, 2 warnings, 113 lines checked