|WARNING| pw127112 [PATCH v4] ethdev: add indirect list flow action

checkpatch at dpdk.org checkpatch at dpdk.org
Fri May 19 14:01:15 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/127112

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#387: FILE: app/test-pmd/cmdline_flow.c:6826:
+^I^I^I^I           rte_flow_action_indirect_list)),$

ERROR:CODE_INDENT: code indent should use tabs where possible
#442: FILE: app/test-pmd/cmdline_flow.c:7273:
+        case INDIRECT_ACTION_FLOW_CONF:$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#442: FILE: app/test-pmd/cmdline_flow.c:7273:
+        case INDIRECT_ACTION_FLOW_CONF:$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#479: FILE: app/test-pmd/cmdline_flow.c:10515:
+		    void __rte_unused *buf, unsigned int __rte_unused size)
 		                      ^

ERROR:CODE_INDENT: code indent should use tabs where possible
#500: FILE: app/test-pmd/cmdline_flow.c:10536:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#500: FILE: app/test-pmd/cmdline_flow.c:10536:
+        action_conf->handle = (typeof(action_conf->handle))$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#564: FILE: app/test-pmd/cmdline_flow.c:11634:
+	if (indlst_conf)
+        printf("created indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#565: FILE: app/test-pmd/cmdline_flow.c:11635:
+        printf("created indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#565: FILE: app/test-pmd/cmdline_flow.c:11635:
+        printf("created indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#566: FILE: app/test-pmd/cmdline_flow.c:11636:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#566: FILE: app/test-pmd/cmdline_flow.c:11636:
+               in->args.vc.attr.group);$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#567: FILE: app/test-pmd/cmdline_flow.c:11637:
+	else
+        printf("cannot create indirect action list configuration %u
",

ERROR:CODE_INDENT: code indent should use tabs where possible
#568: FILE: app/test-pmd/cmdline_flow.c:11638:
+        printf("cannot create indirect action list configuration %u
",$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#568: FILE: app/test-pmd/cmdline_flow.c:11638:
+        printf("cannot create indirect action list configuration %u
",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#569: FILE: app/test-pmd/cmdline_flow.c:11639:
+               in->args.vc.attr.group);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#569: FILE: app/test-pmd/cmdline_flow.c:11639:
+               in->args.vc.attr.group);$

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1244: FILE: lib/ethdev/rte_flow.c:2230:
+					      rte_flow_indir_action_conf *conf,
 					                                 ^

WARNING:FUNCTION_ARGUMENTS: arguments for function declarations should follow identifier
#1273: FILE: lib/ethdev/rte_flow.c:2259:
+int

WARNING:FUNCTION_ARGUMENTS: arguments for function declarations should follow identifier
#1300: FILE: lib/ethdev/rte_flow.c:2286:
+int

WARNING:FUNCTION_ARGUMENTS: arguments for function declarations should follow identifier
#1327: FILE: lib/ethdev/rte_flow.c:2313:
+int

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1480: FILE: lib/ethdev/rte_flow.h:6227:
+					 rte_flow_indir_action_conf *conf,
 					                            ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1589: FILE: lib/ethdev/rte_flow.h:6336:
+					 rte_flow_action_list_handle *handle,
 					                             ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1636: FILE: lib/ethdev/rte_flow.h:6383:
+					  rte_flow_action_list_handle *handle,
 					                              ^

total: 12 errors, 11 warnings, 1389 lines checked


More information about the test-report mailing list