|WARNING| pw131080 [PATCH v2 3/8] net/cpfl: add FXP low level implementation

checkpatch at dpdk.org checkpatch at dpdk.org
Fri Sep 1 13:10:37 CEST 2023


Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/131080

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#199: FILE: drivers/net/cpfl/cpfl_actions.h:108:
+#define CPFL_ACT_PREC_CHECK(p)	((p) > 0 && (p) <= CPFL_ACT_PREC_MAX)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#271: FILE: drivers/net/cpfl/cpfl_actions.h:180:
+#define CPFL_ACT_MAKE_8B(prec, idx, val) \
+	((CPFL_ACT_PREC_SET(prec)) | CPFL_ACT_OP_8B | \
+	 (((idx) << CPFL_ACT_8B_A_INDEX_S) & CPFL_ACT_8B_A_INDEX_M) | \
+	 (((idx) << CPFL_ACT_8B_B_INDEX_S) & CPFL_ACT_8B_B_INDEX_M) | \
+	 (((val) << CPFL_ACT_8B_A_VAL_S) & CPFL_ACT_8B_A_VAL_M) | \
+	 (((val) << CPFL_ACT_8B_B_VAL_S) & CPFL_ACT_8B_B_VAL_M))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'val' - possible side-effects?
#271: FILE: drivers/net/cpfl/cpfl_actions.h:180:
+#define CPFL_ACT_MAKE_8B(prec, idx, val) \
+	((CPFL_ACT_PREC_SET(prec)) | CPFL_ACT_OP_8B | \
+	 (((idx) << CPFL_ACT_8B_A_INDEX_S) & CPFL_ACT_8B_A_INDEX_M) | \
+	 (((idx) << CPFL_ACT_8B_B_INDEX_S) & CPFL_ACT_8B_B_INDEX_M) | \
+	 (((val) << CPFL_ACT_8B_A_VAL_S) & CPFL_ACT_8B_A_VAL_M) | \
+	 (((val) << CPFL_ACT_8B_B_VAL_S) & CPFL_ACT_8B_B_VAL_M))

WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1434: FILE: drivers/net/cpfl/cpfl_rules.c:37:
+		context |= SHIFT_VAL64(cmn_cfg->cache_wr_thru,

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1435: FILE: drivers/net/cpfl/cpfl_rules.c:38:
+				       MEV_RULE_CACHE_WR_THRU);

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1614: FILE: drivers/net/cpfl/cpfl_rules.h:85:
+#define MEV_RULE_CACHE_WR_THRU_S	21

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1615: FILE: drivers/net/cpfl/cpfl_rules.h:86:
+#define MEV_RULE_CACHE_WR_THRU_M	\

WARNING:TYPO_SPELLING: 'THRU' may be misspelled - perhaps 'THROUGH'?
#1616: FILE: drivers/net/cpfl/cpfl_rules.h:87:
+		MAKE_MASK64(0x1, MEV_RULE_CACHE_WR_THRU_S)

WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1755: FILE: drivers/net/cpfl/cpfl_rules.h:226:
+	uint8_t	cache_wr_thru;

WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1802: FILE: drivers/net/cpfl/cpfl_rules.h:273:
+			       uint8_t cache_wr_thru,

WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1817: FILE: drivers/net/cpfl/cpfl_rules.h:288:
+	cfg_cmn->cache_wr_thru = cache_wr_thru;

WARNING:TYPO_SPELLING: 'thru' may be misspelled - perhaps 'through'?
#1817: FILE: drivers/net/cpfl/cpfl_rules.h:288:
+	cfg_cmn->cache_wr_thru = cache_wr_thru;

total: 0 errors, 9 warnings, 3 checks, 1734 lines checked


More information about the test-report mailing list