|WARNING| pw139065 [PATCH] vhost: fix crash caused by accessing a freed vsocket
checkpatch at dpdk.org
checkpatch at dpdk.org
Wed Apr 3 04:32:01 CEST 2024
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139065
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#153: FILE: lib/vhost/fd_man.c:254:
+ vhost_thread_read_lock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: lib/vhost/fd_man.c:254:
+ vhost_thread_read_lock();$
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/vhost/fd_man.c:308:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/vhost/fd_man.c:308:
+ vhost_thread_read_unlock();$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 15)
#192: FILE: lib/vhost/socket.c:466:
while (1) {
+ vhost_thread_read_lock();
ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: lib/vhost/socket.c:467:
+ vhost_thread_read_lock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: lib/vhost/socket.c:467:
+ vhost_thread_read_lock();$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: lib/vhost/socket.c:499:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/vhost/socket.c:499:
+ vhost_thread_read_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: lib/vhost/socket.c:1077:
+ vhost_thread_write_lock();$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (16, 23)
#216: FILE: lib/vhost/socket.c:1087:
} else if (vsocket->is_server) {
[...]
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);
ERROR:CODE_INDENT: code indent should use tabs where possible
#221: FILE: lib/vhost/socket.c:1089:
+ * The vhost thread write lock has been acquired,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: lib/vhost/socket.c:1090:
+ * and fd must be deleted from fdset.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: lib/vhost/socket.c:1092:
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: lib/vhost/socket.c:1092:
+ fdset_del(&vhost_user.fdset, vsocket->socket_fd);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#240: FILE: lib/vhost/socket.c:1104:
+ * The vhost thread write lock has been acquired,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#241: FILE: lib/vhost/socket.c:1105:
+ * and fd must be deleted from fdset.$
ERROR:CODE_INDENT: code indent should use tabs where possible
#249: FILE: lib/vhost/socket.c:1107:
+ fdset_del(&vhost_user.fdset, conn->connfd);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#249: FILE: lib/vhost/socket.c:1107:
+ fdset_del(&vhost_user.fdset, conn->connfd);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#257: FILE: lib/vhost/socket.c:1129:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#257: FILE: lib/vhost/socket.c:1129:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#261: FILE: lib/vhost/socket.c:1133:
+ vhost_thread_write_unlock();$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#284: FILE: lib/vhost/vhost_thread.c:14:
+ rte_rwlock_read_lock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#290: FILE: lib/vhost/vhost_thread.c:20:
+ rte_rwlock_read_unlock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: lib/vhost/vhost_thread.c:26:
+ rte_rwlock_write_lock(&vhost_thread_lock);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: lib/vhost/vhost_thread.c:32:
+ rte_rwlock_write_unlock(&vhost_thread_lock);$
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: Gongming Chen <chengongming1900 at outlook.com>' != 'Signed-off-by: Gongming Chen <chengm11 at chinatelecom.cn>'
total: 11 errors, 16 warnings, 154 lines checked
More information about the test-report
mailing list