diff mbox series

[v2] stack: remove duplicated include of atomic

Message ID 20211013204812.2937199-1-dharmik.thakkar@arm.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [v2] stack: remove duplicated include of atomic |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Dharmik Thakkar Oct. 13, 2021, 8:48 p.m. UTC 
  From: Joyce Kong <joyce.kong@arm.com>

In stack module, remove the header file rte_atomic.h
as it is not being used.

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
v2:
  Change commit message (Olivier)

---
 app/test/test_stack.c | 1 -
 lib/stack/rte_stack.c | 1 -
 lib/stack/rte_stack.h | 1 -
 3 files changed, 3 deletions(-)

Comments

Olivier Matz Oct. 15, 2021, 12:59 p.m. UTC | #1 
On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> From: Joyce Kong <joyce.kong@arm.com>
> 
> In stack module, remove the header file rte_atomic.h
> as it is not being used.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>

Thanks
David Marchand Oct. 19, 2021, 2:02 p.m. UTC | #2 
On Fri, Oct 15, 2021 at 2:59 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Oct 13, 2021 at 03:48:12PM -0500, Dharmik Thakkar wrote:
> > From: Joyce Kong <joyce.kong@arm.com>
> >
> > In stack module, remove the header file rte_atomic.h
> > as it is not being used.
> >
> > Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> > Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 00efb38e2ab8..bc3896143334 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -4,7 +4,6 @@ 
 
 #include <string.h>
 
-#include <rte_atomic.h>
 #include <rte_lcore.h>
 #include <rte_malloc.h>
 #include <rte_random.h>
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index 5e56cd9f0cd3..56bf2c8d6d3d 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -6,7 +6,6 @@ 
 #include <sys/queue.h>
 
 #include <rte_string_fns.h>
-#include <rte_atomic.h>
 #include <rte_eal.h>
 #include <rte_eal_memconfig.h>
 #include <rte_errno.h>
diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h
index 27640f87b245..321f4cec1a10 100644
--- a/lib/stack/rte_stack.h
+++ b/lib/stack/rte_stack.h
@@ -19,7 +19,6 @@ 
 extern "C" {
 #endif
 
-#include <rte_atomic.h>
 #include <rte_compat.h>
 #include <rte_debug.h>
 #include <rte_errno.h>