crypto/octeontx2: fix ESN seqhi
Checks
Commit Message
For current pkt, previous seqhi is used instead of its
guessed seqhi. Fixed it.
Fixes: 5be562bc5b78 ("crypto/octeontx2: support IPsec ESN and anti-replay")
Cc: stable@dpdk.org
Signed-off-by: Archana Muniganti <marchana@marvell.com>
---
drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
Comments
> Subject: [PATCH] crypto/octeontx2: fix ESN seqhi
>
> For current pkt, previous seqhi is used instead of its guessed seqhi. Fixed it.
>
> Fixes: 5be562bc5b78 ("crypto/octeontx2: support IPsec ESN and anti-replay")
> Cc: stable@dpdk.org
>
> Signed-off-by: Archana Muniganti <marchana@marvell.com>
> ---
> drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
Acked-by: Anoob Joseph <anoobj@marvell.com>
> > Subject: [PATCH] crypto/octeontx2: fix ESN seqhi
> >
> > For current pkt, previous seqhi is used instead of its guessed seqhi. Fixed it.
> >
> > Fixes: 5be562bc5b78 ("crypto/octeontx2: support IPsec ESN and anti-
> replay")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Archana Muniganti <marchana@marvell.com>
> > ---
> > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto
Thanks.
@@ -736,6 +736,14 @@ otx2_cpt_enqueue_sec(struct otx2_cpt_qp *qp, struct rte_crypto_op *op,
otx2_err("Anti replay check failed");
return IPSEC_ANTI_REPLAY_FAILED;
}
+
+ if (esn) {
+ seq_in_sa = ((uint64_t)esn_hi << 32) | esn_low;
+ if (seq > seq_in_sa) {
+ sa->esn_low = rte_cpu_to_be_32(seql);
+ sa->esn_hi = rte_cpu_to_be_32(seqh);
+ }
+ }
}
ret = process_inb_sa(op, sess, &qp->meta_info, (void **)&req);
@@ -749,14 +757,6 @@ otx2_cpt_enqueue_sec(struct otx2_cpt_qp *qp, struct rte_crypto_op *op,
ret = otx2_cpt_enqueue_req(qp, pend_q, req, op, sess->cpt_inst_w7,
burst_index);
- if (winsz && esn) {
- seq_in_sa = ((uint64_t)esn_hi << 32) | esn_low;
- if (seq > seq_in_sa) {
- sa->esn_low = rte_cpu_to_be_32(seql);
- sa->esn_hi = rte_cpu_to_be_32(seqh);
- }
- }
-
return ret;
}