diff mbox series

common/cnxk: fix incorrect error checking

Message ID tencent_2800749EBE11469445C462BE78A44E532209@qq.com (mailing list archive)
State Superseded, archived
Headers
Series common/cnxk: fix incorrect error checking |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Weiguo Li Dec. 21, 2021, 8:02 a.m. UTC 
  Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")

Signed-off-by: Weiguo Li <liwg06@foxmail.com>
---
 drivers/common/cnxk/roc_bphy_irq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tomasz Duszynski Jan. 21, 2022, 7:28 p.m. UTC | #1 
On Tue, Dec 21, 2021 at 04:02:20PM +0800, Weiguo Li wrote:
> Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")
>
> Signed-off-by: Weiguo Li <liwg06 at foxmail.com>
> ---
>  drivers/common/cnxk/roc_bphy_irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
> index f4e9b341af..5ba73c98dc 100644
> --- a/drivers/common/cnxk/roc_bphy_irq.c
> +++ b/drivers/common/cnxk/roc_bphy_irq.c
> @@ -261,9 +261,9 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
>  	CPU_SET(curr_cpu, &intr_cpuset);
>  	retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
>  					&intr_cpuset);

Use rc instead. This will generate less changes and will match
local conventions.

> -	if (rc < 0) {
> +	if (retval < 0) {
>  		plt_err("Failed to set affinity mask");
> -		return rc;
> +		return retval;
>  	}
>
>  	irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler;
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
index f4e9b341af..5ba73c98dc 100644
--- a/drivers/common/cnxk/roc_bphy_irq.c
+++ b/drivers/common/cnxk/roc_bphy_irq.c
@@ -261,9 +261,9 @@  roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
 	CPU_SET(curr_cpu, &intr_cpuset);
 	retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
 					&intr_cpuset);
-	if (rc < 0) {
+	if (retval < 0) {
 		plt_err("Failed to set affinity mask");
-		return rc;
+		return retval;
 	}
 
 	irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler;