diff mbox series

[v2,09/11] vhost: fix missing C++ guards

Message ID 20220216151456.114242-10-brian.dooley@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series add missing C++ guards |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Dooley, Brian Feb. 16, 2022, 3:14 p.m. UTC 
  Some public header files were missing 'extern "C"' C++ guards,
and couldn't be used by C++ applications. Add the missing guards.

Fixes: d7280c9fffcb ("vhost: support selective datapath")
Fixes: 78639d54563a ("vhost: introduce async enqueue registration API")
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Fixes: 94c16e89d779 ("vhost: mark vDPA driver API as internal")
Cc: zhihong.wang@intel.com
Cc: patrick.fu@intel.com
Cc: roy.fan.zhang@intel.com
Cc: maxime.coquelin@redhat.com
Cc: stable@dpdk.org

Signed-off-by: Brian Dooley <brian.dooley@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

---
v2: Added missing apostrophe to commit message.
---
 lib/vhost/rte_vdpa.h         | 9 +++++++++
 lib/vhost/rte_vhost_async.h  | 8 ++++++++
 lib/vhost/rte_vhost_crypto.h | 8 ++++++++
 lib/vhost/vdpa_driver.h      | 8 ++++++++
 4 files changed, 33 insertions(+)

Comments

Chenbo Xia Feb. 17, 2022, 7:50 a.m. UTC | #1 
> -----Original Message-----
> From: Dooley, Brian <brian.dooley@intel.com>
> Sent: Wednesday, February 16, 2022 11:15 PM
> To: dev@dpdk.org
> Cc: Dooley, Brian <brian.dooley@intel.com>; zhihong.wang@intel.com;
> patrick.fu@intel.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> maxime.coquelin@redhat.com; stable@dpdk.org; Richardson, Bruce
> <bruce.richardson@intel.com>; Xia, Chenbo <chenbo.xia@intel.com>; Jay Zhou
> <jianjay.zhou@huawei.com>; Thomas Monjalon <thomas@monjalon.net>
> Subject: [PATCH v2 09/11] vhost: fix missing C++ guards
> 
> Some public header files were missing 'extern "C"' C++ guards,
> and couldn't be used by C++ applications. Add the missing guards.
> 
> Fixes: d7280c9fffcb ("vhost: support selective datapath")
> Fixes: 78639d54563a ("vhost: introduce async enqueue registration API")
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> Fixes: 94c16e89d779 ("vhost: mark vDPA driver API as internal")
> Cc: zhihong.wang@intel.com
> Cc: patrick.fu@intel.com

Zhihong and Patrick is no longer in intel, can delete both if there's new version

For this patch:

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

> Cc: roy.fan.zhang@intel.com
> Cc: maxime.coquelin@redhat.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Brian Dooley <brian.dooley@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> ---
> v2: Added missing apostrophe to commit message.
> ---
>  lib/vhost/rte_vdpa.h         | 9 +++++++++
>  lib/vhost/rte_vhost_async.h  | 8 ++++++++
>  lib/vhost/rte_vhost_crypto.h | 8 ++++++++
>  lib/vhost/vdpa_driver.h      | 8 ++++++++
>  4 files changed, 33 insertions(+)
diff mbox series

Patch

diff --git a/lib/vhost/rte_vdpa.h b/lib/vhost/rte_vdpa.h
index 1437f400bf..6ac85d1bbf 100644
--- a/lib/vhost/rte_vdpa.h
+++ b/lib/vhost/rte_vdpa.h
@@ -5,6 +5,10 @@ 
 #ifndef _RTE_VDPA_H_
 #define _RTE_VDPA_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /**
  * @file
  *
@@ -183,4 +187,9 @@  rte_vdpa_get_stats(struct rte_vdpa_device *dev, uint16_t qid,
  */
 int
 rte_vdpa_reset_stats(struct rte_vdpa_device *dev, uint16_t qid);
+
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _RTE_VDPA_H_ */
diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
index 838c4778cc..f1293c6a9d 100644
--- a/lib/vhost/rte_vhost_async.h
+++ b/lib/vhost/rte_vhost_async.h
@@ -5,6 +5,10 @@ 
 #ifndef _RTE_VHOST_ASYNC_H_
 #define _RTE_VHOST_ASYNC_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <stdint.h>
 
 #include <rte_compat.h>
@@ -183,4 +187,8 @@  uint16_t rte_vhost_clear_queue_thread_unsafe(int vid, uint16_t queue_id,
 __rte_experimental
 int rte_vhost_async_dma_configure(int16_t dma_id, uint16_t vchan_id);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _RTE_VHOST_ASYNC_H_ */
diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h
index f54d731139..b49e389579 100644
--- a/lib/vhost/rte_vhost_crypto.h
+++ b/lib/vhost/rte_vhost_crypto.h
@@ -5,6 +5,10 @@ 
 #ifndef _VHOST_CRYPTO_H_
 #define _VHOST_CRYPTO_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <stdint.h>
 
 #include <rte_compat.h>
@@ -132,4 +136,8 @@  uint16_t
 rte_vhost_crypto_finalize_requests(struct rte_crypto_op **ops,
 		uint16_t nb_ops, int *callfds, uint16_t *nb_callfds);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /**< _VHOST_CRYPTO_H_ */
diff --git a/lib/vhost/vdpa_driver.h b/lib/vhost/vdpa_driver.h
index fddbd50652..88138be34a 100644
--- a/lib/vhost/vdpa_driver.h
+++ b/lib/vhost/vdpa_driver.h
@@ -5,6 +5,10 @@ 
 #ifndef _VDPA_DRIVER_H_
 #define _VDPA_DRIVER_H_
 
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <stdbool.h>
 
 #include <rte_compat.h>
@@ -144,4 +148,8 @@  __rte_internal
 int
 rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _VDPA_DRIVER_H_ */