net/ice: fix overwriting of LSE bit by DCF
Checks
Commit Message
After enabling DCF on a VF, the ice driver stops receiving
link updates on it's Admin Receive Queue. During the init
of DCF ice_aqc_opc_get_link_status command is send to the
firmware without LSE(LINK STATUS EVENT) bit set. This prevents
the ice driver from receiving up/down events, and correspondingly
updating netdev.
Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
---
drivers/net/ice/ice_dcf_parent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, February 18, 2022 9:35 PM
> To: Wilczynski, Michal <michal.wilczynski@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/ice: fix overwriting of LSE bit by DCF
>
> > -----Original Message-----
> > From: Wilczynski, Michal <michal.wilczynski@intel.com>
> > Sent: Friday, February 18, 2022 19:57
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wilczynski, Michal
> > <michal.wilczynski@intel.com>
> > Subject: [PATCH] net/ice: fix overwriting of LSE bit by DCF
> >
> > After enabling DCF on a VF, the ice driver stops receiving link
> > updates on it's Admin Receive Queue. During the init of DCF
> > ice_aqc_opc_get_link_status command is send to the firmware without
> > LSE(LINK STATUS EVENT) bit set. This prevents the ice driver from
> > receiving up/down events, and correspondingly updating netdev.
> >
> > Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> > ---
> > drivers/net/ice/ice_dcf_parent.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
Applied to dpdk-next-net-intel after added below fixline and cc stable
Fixes: 0b02c9519432 ("net/ice: handle PF initialization by DCF")
Cc: stable@dpdk.org
Thanks
Qi
>
> >
> > --
> > 2.25.1
>
@@ -340,7 +340,7 @@ ice_dcf_init_parent_hw(struct ice_hw *hw)
goto err_unroll_alloc;
/* Initialize port_info struct with link information */
- status = ice_aq_get_link_info(hw->port_info, false, NULL, NULL);
+ status = ice_aq_get_link_info(hw->port_info, true, NULL, NULL);
if (status)
goto err_unroll_alloc;