app/testpmd: add help messages for multi-process
Checks
Commit Message
From: Huisong Li <lihuisong@huawei.com>
This patch adds help messages for multi-process.
Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
app/test-pmd/parameters.c | 2 ++
1 file changed, 2 insertions(+)
Comments
28/02/2022 04:26, Min Hu (Connor):
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -210,6 +210,8 @@ usage(char* progname)
> printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
> " 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
> " 0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
> + printf(" --num-procs: the number of processes which will be used\n");
> + printf(" --proc-id : the id of the current process (id < num-procs)\n");
> }
Can we find a better order instead of just adding these options at the end?
Hi, Thomas,
I have adjust the postions in v2. I think the new postion will
be OK.
Thanks.
在 2022/2/28 16:57, Thomas Monjalon 写道:
> 28/02/2022 04:26, Min Hu (Connor):
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -210,6 +210,8 @@ usage(char* progname)
>> printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
>> " 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
>> " 0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
>> + printf(" --num-procs: the number of processes which will be used\n");
>> + printf(" --proc-id : the id of the current process (id < num-procs)\n");
>> }
>
> Can we find a better order instead of just adding these options at the end?
>
>
> .
>
01/03/2022 04:41, Min Hu (Connor):
> Hi, Thomas,
> I have adjust the postions in v2. I think the new postion will
> be OK.
No, I think you just picked a random position.
I expect more from a regular contributor like you.
Hi, Thomas,
Maybe I do not catch the regularity of the order of parameters.
The patch has been fixed in v3.
Thanks.
在 2022/3/1 16:36, Thomas Monjalon 写道:
> 01/03/2022 04:41, Min Hu (Connor):
>> Hi, Thomas,
>> I have adjust the postions in v2. I think the new postion will
>> be OK.
>
> No, I think you just picked a random position.
> I expect more from a regular contributor like you.
>
>
>
> .
>
@@ -210,6 +210,8 @@ usage(char* progname)
printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
" 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
" 0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
+ printf(" --num-procs: the number of processes which will be used\n");
+ printf(" --proc-id : the id of the current process (id < num-procs)\n");
}
#ifdef RTE_LIB_CMDLINE