app/testpmd: add help messages for multi-process

Message ID 20220228032617.46618-1-humin29@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: add help messages for multi-process |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

humin (Q) Feb. 28, 2022, 3:26 a.m. UTC
  From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Thomas Monjalon Feb. 28, 2022, 8:57 a.m. UTC | #1
28/02/2022 04:26, Min Hu (Connor):
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -210,6 +210,8 @@ usage(char* progname)
>  	printf("  --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
>  	       "    0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
>  	       "    0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
> +	printf("  --num-procs: the number of processes which will be used\n");
> +	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
>  }

Can we find a better order instead of just adding these options at the end?
  
humin (Q) March 1, 2022, 3:41 a.m. UTC | #2
Hi, Thomas,
	I have adjust the postions in v2. I think the new postion will
be OK.
	Thanks.

在 2022/2/28 16:57, Thomas Monjalon 写道:
> 28/02/2022 04:26, Min Hu (Connor):
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -210,6 +210,8 @@ usage(char* progname)
>>   	printf("  --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
>>   	       "    0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
>>   	       "    0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
>> +	printf("  --num-procs: the number of processes which will be used\n");
>> +	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
>>   }
> 
> Can we find a better order instead of just adding these options at the end?
> 
> 
> .
>
  
Thomas Monjalon March 1, 2022, 8:36 a.m. UTC | #3
01/03/2022 04:41, Min Hu (Connor):
> Hi, Thomas,
> 	I have adjust the postions in v2. I think the new postion will
> be OK.

No, I think you just picked a random position.
I expect more from a regular contributor like you.
  
humin (Q) March 1, 2022, 9:19 a.m. UTC | #4
Hi, Thomas,
	Maybe I do not catch the regularity of the order of parameters.
	The patch has been fixed in v3.
	Thanks.

在 2022/3/1 16:36, Thomas Monjalon 写道:
> 01/03/2022 04:41, Min Hu (Connor):
>> Hi, Thomas,
>> 	I have adjust the postions in v2. I think the new postion will
>> be OK.
> 
> No, I think you just picked a random position.
> I expect more from a regular contributor like you.
> 
> 
> 
> .
>
  

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..affebd87f3 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -210,6 +210,8 @@  usage(char* progname)
 	printf("  --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n"
 	       "    0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n"
 	       "    0x01 - hairpin ports loop, 0x00 - hairpin port self\n");
+	printf("  --num-procs: the number of processes which will be used\n");
+	printf("  --proc-id  : the id of the current process (id < num-procs)\n");
 }
 
 #ifdef RTE_LIB_CMDLINE