[v4] app/testpmd: add help messages for multi-process

Message ID 20220304012748.53004-1-humin29@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v4] app/testpmd: add help messages for multi-process |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

humin (Q) March 4, 2022, 1:27 a.m. UTC
  From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs <N>, where N is the total number of symmetric_mp instances
that will be run side-by-side to perform packet processing. This parameter
is used to configure the appropriate number of receive queues on each
network port.

--proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
of processes, specified above). This identifies which symmetric_mp instance
is being run, so that each process can read a unique receive queue on each
network port.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v4:
* update description for parameters.
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Zhang, Yuying March 4, 2022, 2:50 a.m. UTC | #1
Hi Connor,

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, March 4, 2022 9:28 AM
> To: dev@dpdk.org
> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
> Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH v4] app/testpmd: add help messages for multi-process
> 
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances that
> will be run side-by-side to perform packet processing. This parameter is used to
> configure the appropriate number of receive queues on each network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> processes, specified above). This identifies which symmetric_mp instance is
> being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>  app/test-pmd/parameters.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> daf6a31b2b..908e8a15f5 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>  	       "extended statistics to show. Used with --stats-period "
>  	       "specified or interactive commands that show Rx/Tx statistics "
>  	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances that
> will be run side-by-side\n");
> +	printf("  --proc-id  : the id of the current process (id < num-procs)
> +to identify which symmetric_mp instance is being run\n");

Could you delete the space before colon?

>  	printf("  --nb-cores=N: set the number of forwarding cores "
>  	       "(1 <= N <= %d).\n", nb_lcores);
>  	printf("  --nb-ports=N: set the number of forwarding ports "
> --
> 2.33.0
  
humin (Q) March 4, 2022, 6:29 a.m. UTC | #2
Hi,

在 2022/3/4 10:50, Zhang, Yuying 写道:
> Hi Connor,
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Friday, March 4, 2022 9:28 AM
>> To: dev@dpdk.org
>> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
>> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
>> Deep <aman.deep.singh@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>;
>> Ajit Khaparde <ajit.khaparde@broadcom.com>; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH v4] app/testpmd: add help messages for multi-process
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs <N>, where N is the total number of symmetric_mp instances that
>> will be run side-by-side to perform packet processing. This parameter is used to
>> configure the appropriate number of receive queues on each network port.
>>
>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>> processes, specified above). This identifies which symmetric_mp instance is
>> being run, so that each process can read a unique receive queue on each
>> network port.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> v4:
>> * update description for parameters.
>> v3,v2:
>> * adjust the position of parameters.
>> ---
>>   app/test-pmd/parameters.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>> daf6a31b2b..908e8a15f5 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>> @@ -61,6 +61,8 @@ usage(char* progname)
>>   	       "extended statistics to show. Used with --stats-period "
>>   	       "specified or interactive commands that show Rx/Tx statistics "
>>   	       "(i.e. 'show port stats').\n");
>> +	printf("  --num-procs: the total number of symmetric_mp instances that
>> will be run side-by-side\n");
>> +	printf("  --proc-id  : the id of the current process (id < num-procs)
>> +to identify which symmetric_mp instance is being run\n");
> 
> Could you delete the space before colon?
already delete the space in v5, thanks.
> 
>>   	printf("  --nb-cores=N: set the number of forwarding cores "
>>   	       "(1 <= N <= %d).\n", nb_lcores);
>>   	printf("  --nb-ports=N: set the number of forwarding ports "
>> --
>> 2.33.0
> 
> .
>
  

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..908e8a15f5 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,8 @@  usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");
+	printf("  --proc-id  : the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "