diff mbox series

[v5] app/testpmd: add help messages for multi-process

Message ID 20220304062642.54725-1-humin29@huawei.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series [v5] app/testpmd: add help messages for multi-process |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

humin (Q) March 4, 2022, 6:26 a.m. UTC 
  From: Huisong Li <lihuisong@huawei.com>

This patch adds help messages for multi-process.
--num-procs <N>, where N is the total number of symmetric_mp instances
that will be run side-by-side to perform packet processing. This parameter
is used to configure the appropriate number of receive queues on each
network port.

--proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
of processes, specified above). This identifies which symmetric_mp instance
is being run, so that each process can read a unique receive queue on each
network port.

Fixes: a550baf24af9 ("app/testpmd: support multi-process")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v5:
* delete space
v4:
* update description for parameters.
v3,v2:
* adjust the position of parameters.
---
 app/test-pmd/parameters.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Zhang, Yuying March 4, 2022, 9:11 a.m. UTC | #1 
Hi Minhu,

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Friday, March 4, 2022 2:27 PM
> To: dev@dpdk.org
> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh
> <ferruh.yigit@intel.com>
> Subject: [PATCH v5] app/testpmd: add help messages for multi-process
> 
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances
> that will be run side-by-side to perform packet processing. This parameter is
> used to configure the appropriate number of receive queues on each
> network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> processes, specified above). This identifies which symmetric_mp instance is
> being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Acked-by: Yuying Zhang <yuying.zhang@intel.com>

> ---
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>  app/test-pmd/parameters.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
> daf6a31b2b..6c4253ae61 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>  	       "extended statistics to show. Used with --stats-period "
>  	       "specified or interactive commands that show Rx/Tx statistics "
>  	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances
> that will be run side-by-side\n");
> +	printf("  --proc-id: the id of the current process (id < num-procs) to
> +identify which symmetric_mp instance is being run\n");
>  	printf("  --nb-cores=N: set the number of forwarding cores "
>  	       "(1 <= N <= %d).\n", nb_lcores);
>  	printf("  --nb-ports=N: set the number of forwarding ports "
> --
> 2.33.0
Ferruh Yigit March 4, 2022, 2:46 p.m. UTC | #2 
On 3/4/2022 6:26 AM, Min Hu (Connor) wrote:
> From: Huisong Li <lihuisong@huawei.com>
> 
> This patch adds help messages for multi-process.
> --num-procs <N>, where N is the total number of symmetric_mp instances
> that will be run side-by-side to perform packet processing. This parameter
> is used to configure the appropriate number of receive queues on each
> network port.
> 
> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number
> of processes, specified above). This identifies which symmetric_mp instance
> is being run, so that each process can read a unique receive queue on each
> network port.
> 
> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v5:
> * delete space
> v4:
> * update description for parameters.
> v3,v2:
> * adjust the position of parameters.
> ---
>   app/test-pmd/parameters.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index daf6a31b2b..6c4253ae61 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -61,6 +61,8 @@ usage(char* progname)
>   	       "extended statistics to show. Used with --stats-period "
>   	       "specified or interactive commands that show Rx/Tx statistics "
>   	       "(i.e. 'show port stats').\n");
> +	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");

I am not exactly sure what is 'symmetric' in 'symmetric_mp' here,
there is a sample application with this name but I guess 'symmetric'
is related to that sample functionality.

Would you mind if I change 'symmetric_mp' with 'multi-process'
while applying?

> +	printf("  --proc-id: the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
>   	printf("  --nb-cores=N: set the number of forwarding cores "
>   	       "(1 <= N <= %d).\n", nb_lcores);
>   	printf("  --nb-ports=N: set the number of forwarding ports "
Ferruh Yigit March 4, 2022, 3:35 p.m. UTC | #3 
On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
> Hi Minhu,
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Friday, March 4, 2022 2:27 PM
>> To: dev@dpdk.org
>> Cc: Huisong Li <lihuisong@huawei.com>; stable@dpdk.org; Min Hu
>> <humin29@huawei.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Singh, Aman
>> Deep <aman.deep.singh@intel.com>; Zhang, Yuying
>> <yuying.zhang@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
>> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>
>> Subject: [PATCH v5] app/testpmd: add help messages for multi-process
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> This patch adds help messages for multi-process.
>> --num-procs <N>, where N is the total number of symmetric_mp instances
>> that will be run side-by-side to perform packet processing. This parameter is
>> used to configure the appropriate number of receive queues on each
>> network port.
>>
>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>> processes, specified above). This identifies which symmetric_mp instance is
>> being run, so that each process can read a unique receive queue on each
>> network port.
>>
>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> 
> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
> 

Updated 'symmetric_mp' -> 'multi-process', with this change
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
Thomas Monjalon March 6, 2022, 10:52 p.m. UTC | #4 
04/03/2022 16:35, Ferruh Yigit:
> On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
> > From: Min Hu (Connor) <humin29@huawei.com>
> >> From: Huisong Li <lihuisong@huawei.com>
> >>
> >> This patch adds help messages for multi-process.
> >> --num-procs <N>, where N is the total number of symmetric_mp instances
> >> that will be run side-by-side to perform packet processing. This parameter is
> >> used to configure the appropriate number of receive queues on each
> >> network port.
> >>
> >> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
> >> processes, specified above). This identifies which symmetric_mp instance is
> >> being run, so that each process can read a unique receive queue on each
> >> network port.
> >>
> >> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> > 
> > Acked-by: Yuying Zhang <yuying.zhang@intel.com>
> > 
> 
> Updated 'symmetric_mp' -> 'multi-process', with this change
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied to dpdk-next-net/main, thanks.

Why not reusing these defines?

#define PARAM_PROC_ID "proc-id"
#define PARAM_NUM_PROCS "num-procs"

Why not having "N" in the help messages like others?

I won't pull it in main.
Please rework and try to improve the description to make it shorter
and easier to understand.
humin (Q) March 7, 2022, 1:05 a.m. UTC | #5 
Hi, Thomas,
	v6 has been sent, thanks.

在 2022/3/7 6:52, Thomas Monjalon 写道:
> 04/03/2022 16:35, Ferruh Yigit:
>> On 3/4/2022 9:11 AM, Zhang, Yuying wrote:
>>> From: Min Hu (Connor) <humin29@huawei.com>
>>>> From: Huisong Li <lihuisong@huawei.com>
>>>>
>>>> This patch adds help messages for multi-process.
>>>> --num-procs <N>, where N is the total number of symmetric_mp instances
>>>> that will be run side-by-side to perform packet processing. This parameter is
>>>> used to configure the appropriate number of receive queues on each
>>>> network port.
>>>>
>>>> --proc-id <n>, where n is a numeric value in the range 0 <= n < N (number of
>>>> processes, specified above). This identifies which symmetric_mp instance is
>>>> being run, so that each process can read a unique receive queue on each
>>>> network port.
>>>>
>>>> Fixes: a550baf24af9 ("app/testpmd: support multi-process")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>>>
>>> Acked-by: Yuying Zhang <yuying.zhang@intel.com>
>>>
>>
>> Updated 'symmetric_mp' -> 'multi-process', with this change
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Applied to dpdk-next-net/main, thanks.
> 
> Why not reusing these defines?
> 
> #define PARAM_PROC_ID "proc-id"
> #define PARAM_NUM_PROCS "num-procs"
> 
> Why not having "N" in the help messages like others?
> 
> I won't pull it in main.
> Please rework and try to improve the description to make it shorter
> and easier to understand.
> 
> 
> .
>
diff mbox series

Patch

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index daf6a31b2b..6c4253ae61 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -61,6 +61,8 @@  usage(char* progname)
 	       "extended statistics to show. Used with --stats-period "
 	       "specified or interactive commands that show Rx/Tx statistics "
 	       "(i.e. 'show port stats').\n");
+	printf("  --num-procs: the total number of symmetric_mp instances that will be run side-by-side\n");
+	printf("  --proc-id: the id of the current process (id < num-procs) to identify which symmetric_mp instance is being run\n");
 	printf("  --nb-cores=N: set the number of forwarding cores "
 	       "(1 <= N <= %d).\n", nb_lcores);
 	printf("  --nb-ports=N: set the number of forwarding ports "