net/sfc: do not spam logs on tunnel restore info errors

Message ID 20220306161206.1446154-1-ivan.malov@oktetlabs.ru (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/sfc: do not spam logs on tunnel restore info errors |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Ivan Malov March 6, 2022, 4:12 p.m. UTC
  OvS might invoke this API on its data path, out of sync
with its control plane. If the control path has already
deactivated the tunnel context entry, these invocations
will produce quite a few error printouts. Suppress that.

Fixes: 7e5b479803c3 ("net/sfc: implement control path operations in tunnel offload")
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
 drivers/net/sfc/sfc_flow_tunnel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ferruh Yigit March 8, 2022, 12:23 p.m. UTC | #1
On 3/6/2022 4:12 PM, Ivan Malov wrote:
> OvS might invoke this API on its data path, out of sync
> with its control plane. If the control path has already
> deactivated the tunnel context entry, these invocations
> will produce quite a few error printouts. Suppress that.
> 
> Fixes: 7e5b479803c3 ("net/sfc: implement control path operations in tunnel offload")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied to dpdk-next-net/main, thanks.
  

Patch

diff --git a/drivers/net/sfc/sfc_flow_tunnel.c b/drivers/net/sfc/sfc_flow_tunnel.c
index e9eca90012..af5941c1ba 100644
--- a/drivers/net/sfc/sfc_flow_tunnel.c
+++ b/drivers/net/sfc/sfc_flow_tunnel.c
@@ -433,7 +433,7 @@  sfc_flow_tunnel_get_restore_info(struct rte_eth_dev *dev,
 	ft = &sa->flow_tunnels[ft_id];
 
 	if (ft->refcnt == 0) {
-		sfc_err(sa, "tunnel offload: get_restore_info: tunnel=%u does not exist",
+		sfc_dbg(sa, "tunnel offload: get_restore_info: tunnel=%u does not exist",
 			ft_id);
 		rc = ENOENT;
 		goto fail;