diff mbox series

eal/windows: fix data race when creating threads

Message ID 1646897708-3462-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series eal/windows: fix data race when creating threads |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS

Commit Message

Tyler Retzlaff March 10, 2022, 7:35 a.m. UTC 
  create lcore worker threads suspended and then subsequently resume to
allow &lcore_config[i].thread_id be stored before eal_thread_loop
execution.

Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code")
Cc: anand.rawat@intel.com
Cc: stable@dpdk.org

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/windows/eal_thread.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Dmitry Kozlyuk March 10, 2022, 4:19 p.m. UTC | #1 
Hi Tyler,

2022-03-09 23:35 (UTC-0800), Tyler Retzlaff:
> create lcore worker threads suspended and then subsequently resume to
> allow &lcore_config[i].thread_id be stored before eal_thread_loop
> execution.
> 
> Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code")
> Cc: anand.rawat@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

It takes some effort to correlate &lcore_config[i].thread_id
with the code in the patch and knowledge of CreateThread()
to understand the root cause.
I suggest prepending an explanation to your commit message:

	eal_thread_loop() uses lcore_config[i].thread_id,
	which is stored upon the return from CreateThread().
	Per documentation, eal_thread_loop() can start
	before CreateThread() returns and the ID is stored.

> ---
>  lib/eal/windows/eal_thread.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/eal/windows/eal_thread.c b/lib/eal/windows/eal_thread.c
> index 54fa93f..ff84cb4 100644
> --- a/lib/eal/windows/eal_thread.c
> +++ b/lib/eal/windows/eal_thread.c
> @@ -150,13 +150,18 @@
>  
>  	th = CreateThread(NULL, 0,
>  		(LPTHREAD_START_ROUTINE)(ULONG_PTR)eal_thread_loop,
> -						NULL, 0, (LPDWORD)thread);
> +						NULL, CREATE_SUSPENDED, (LPDWORD)thread);
>  	if (!th)
>  		return -1;
>  
>  	SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS);
>  	SetThreadPriority(th, THREAD_PRIORITY_NORMAL);
>  
> +	if (ResumeThread(th) == (DWORD)-1) {
> +		(void)CloseHandle(th);
> +		return -1;
> +	}
> +
>  	return 0;
>  }
>
Thomas Monjalon March 30, 2022, 5:04 p.m. UTC | #2 
10/03/2022 17:19, Dmitry Kozlyuk:
> Hi Tyler,
> 
> 2022-03-09 23:35 (UTC-0800), Tyler Retzlaff:
> > create lcore worker threads suspended and then subsequently resume to
> > allow &lcore_config[i].thread_id be stored before eal_thread_loop
> > execution.
> > 
> > Fixes: 53ffd9f080fc ("eal/windows: add minimum viable code")
> > Cc: anand.rawat@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> 
> It takes some effort to correlate &lcore_config[i].thread_id
> with the code in the patch and knowledge of CreateThread()
> to understand the root cause.
> I suggest prepending an explanation to your commit message:
> 
> 	eal_thread_loop() uses lcore_config[i].thread_id,
> 	which is stored upon the return from CreateThread().
> 	Per documentation, eal_thread_loop() can start
> 	before CreateThread() returns and the ID is stored.

There was now reply to this suggestion after 3 weeks,
so I've decided to include it.

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/windows/eal_thread.c b/lib/eal/windows/eal_thread.c
index 54fa93f..ff84cb4 100644
--- a/lib/eal/windows/eal_thread.c
+++ b/lib/eal/windows/eal_thread.c
@@ -150,13 +150,18 @@ 
 
 	th = CreateThread(NULL, 0,
 		(LPTHREAD_START_ROUTINE)(ULONG_PTR)eal_thread_loop,
-						NULL, 0, (LPDWORD)thread);
+						NULL, CREATE_SUSPENDED, (LPDWORD)thread);
 	if (!th)
 		return -1;
 
 	SetPriorityClass(GetCurrentProcess(), NORMAL_PRIORITY_CLASS);
 	SetThreadPriority(th, THREAD_PRIORITY_NORMAL);
 
+	if (ResumeThread(th) == (DWORD)-1) {
+		(void)CloseHandle(th);
+		return -1;
+	}
+
 	return 0;
 }