diff mbox series

app/testpmd: fixed using strtoull with 64-bit variables

Message ID 20220310175023.2552-2-adham@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series app/testpmd: fixed using strtoull with 64-bit variables |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Adham Masarwah March 10, 2022, 5:50 p.m. UTC 
  Replaced using strtoul with strtoull when converting to
64-bit mask field.
In Windows strtoul returns 32-bit values which cause an
issue with show RSS reta.

Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
Cc: stable@dpdk.org

Signed-off-by: Adham Masarwah <adham@nvidia.com>
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Singh, Aman Deep March 11, 2022, 9:40 a.m. UTC | #1 
On 3/10/2022 11:20 PM, Adham Masarwah wrote:
> Replaced using strtoul with strtoull when converting to
> 64-bit mask field.
> In Windows strtoul returns 32-bit values which cause an
> issue with show RSS reta.
>
> Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
> Cc:stable@dpdk.org
>
> Signed-off-by: Adham Masarwah<adham@nvidia.com>
> ---


Acked-by: Aman Singh <aman.deep.singh@intel.com>

As Windowuses the|LLP64 data model.|


>   app/test-pmd/cmdline.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4ba8da2b0..efa02bd301 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3127,7 +3127,7 @@ showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
>   		return -1;
>   	}
>   	for (i = 0; i < ret; i++)
> -		conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
> +		conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
>   
>   	return 0;
>   }
Thomas Monjalon March 14, 2022, 8:25 p.m. UTC | #2 
> > Replaced using strtoul with strtoull when converting to
> > 64-bit mask field.
> > In Windows strtoul returns 32-bit values which cause an
> > issue with show RSS reta.
> >
> > Fixes: 66c594904ac ("ethdev: support multiple sizes of redirection table")
> > Cc:stable@dpdk.org
> >
> > Signed-off-by: Adham Masarwah<adham@nvidia.com>
> 
> Acked-by: Aman Singh <aman.deep.singh@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b4ba8da2b0..efa02bd301 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3127,7 +3127,7 @@  showport_parse_reta_config(struct rte_eth_rss_reta_entry64 *conf,
 		return -1;
 	}
 	for (i = 0; i < ret; i++)
-		conf[i].mask = (uint64_t)strtoul(str_fld[i], &end, 0);
+		conf[i].mask = (uint64_t)strtoull(str_fld[i], &end, 0);
 
 	return 0;
 }