sw_evdev: report correct device name

Message ID 20220713182450.257336-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series sw_evdev: report correct device name |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Stephen Hemminger July 13, 2022, 6:24 p.m. UTC
  The software eventdev PMD reports todo-fix-name as the
device name. Looks like simple fix.

Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/event/sw/sw_evdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Van Haaren, Harry July 14, 2022, 7:45 a.m. UTC | #1
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 13, 2022 7:25 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> Hunt, David <david.hunt@intel.com>
> Subject: [PATCH] sw_evdev: report correct device name
> 
> The software eventdev PMD reports todo-fix-name as the
> device name. Looks like simple fix.
>
> Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Simple fix, but does what it needs! Thanks;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip diff>
  
Jerin Jacob Sept. 13, 2022, 2:11 p.m. UTC | #2
On Thu, Jul 14, 2022 at 1:15 PM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
>
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, July 13, 2022 7:25 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; Richardson, Bruce <bruce.richardson@intel.com>;
> > Hunt, David <david.hunt@intel.com>
> > Subject: [PATCH] sw_evdev: report correct device name
> >
> > The software eventdev PMD reports todo-fix-name as the
> > device name. Looks like simple fix.
> >
> > Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Simple fix, but does what it needs! Thanks;
>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


Updated the git commit as follows to fix ./devtools/check-git-log.sh
issues and applied to dpdk-next-net-eventdev/for-main. Thanks

    event/sw: report correct device name

    The software eventdev PMD reports todo-fix-name as the
    device name.

    Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging")
    Cc: stable@dpdk.org

    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

>
> <snip diff>
  

Patch

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b5c..c9efe35bf428 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -622,8 +622,8 @@  sw_dump(struct rte_eventdev *dev, FILE *f)
 			"Ordered", "Atomic", "Parallel", "Directed"
 	};
 	uint32_t i;
-	fprintf(f, "EventDev %s: ports %d, qids %d\n", "todo-fix-name",
-			sw->port_count, sw->qid_count);
+	fprintf(f, "EventDev %s: ports %d, qids %d\n",
+		dev->data->name, sw->port_count, sw->qid_count);
 
 	fprintf(f, "\trx   %"PRIu64"\n\tdrop %"PRIu64"\n\ttx   %"PRIu64"\n",
 		sw->stats.rx_pkts, sw->stats.rx_dropped, sw->stats.tx_pkts);