[v2] dumpcap: fix interface parameter check.

Message ID 20220912125328.236907-1-arshdeep.kaur@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] dumpcap: fix interface parameter check. |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Kaur, Arshdeep Sept. 12, 2022, 12:53 p.m. UTC
  Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")
Signed-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>
---
 app/dumpcap/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Pattan, Reshma Sept. 12, 2022, 1:06 p.m. UTC | #1
> -----Original Message-----
> From: Arshdeep Kaur <arshdeep.kaur@intel.com>
> Sent: Monday, September 12, 2022 1:53 PM
> To: dev@dpdk.org
> Subject: [PATCH v2] dumpcap: fix interface parameter check.
> 
> Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application")

Can you add short commit message description .

Thanks,
Reshma
  

Patch

diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c
index a6041d4ff4..8972c45a71 100644
--- a/app/dumpcap/main.c
+++ b/app/dumpcap/main.c
@@ -240,7 +240,7 @@  static void select_interface(const char *arg)
 {
 	uint16_t port;
 
-	if (strcmp(arg, "*"))
+	if (!strcmp(arg, "*"))
 		select_all_interfaces();
 	else if (rte_eth_dev_get_port_by_name(arg, &port) == 0)
 		add_interface(port, arg);