diff mbox series

[v1,1/2] test/bbdev: fix possible div by zero issue

Message ID 20230309033624.61660-2-hernan.vargas@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series test-bbdev coverity fixes |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Hernan Vargas March 9, 2023, 3:36 a.m. UTC 
  Add extra check at function level to ensure num_ops cannot be 0.

Coverity issue: 383647
Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G")
Cc: stable@dpdk.org

Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
 app/test-bbdev/test_bbdev_perf.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Maxime Coquelin March 16, 2023, 2:09 p.m. UTC | #1 
On 3/9/23 04:36, Hernan Vargas wrote:
> Add extra check at function level to ensure num_ops cannot be 0.
> 
> Coverity issue: 383647
> Fixes: f0d288bca467 ("test/bbdev: add support for BLER for 4G")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
>   app/test-bbdev/test_bbdev_perf.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
> index e56d314e93b5..15ebcdfc1556 100644
> --- a/app/test-bbdev/test_bbdev_perf.c
> +++ b/app/test-bbdev/test_bbdev_perf.c
> @@ -3722,6 +3722,7 @@ bler_pmd_lcore_ldpc_dec(void *arg)
>   
>   	TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST),
>   			"BURST_SIZE should be <= %u", MAX_BURST);
> +	TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0");
>   
>   	rte_bbdev_info_get(tp->dev_id, &info);
>   
> @@ -3856,6 +3857,7 @@ bler_pmd_lcore_turbo_dec(void *arg)
>   
>   	TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST),
>   			"BURST_SIZE should be <= %u", MAX_BURST);
> +	TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0");
>   
>   	rte_bbdev_info_get(tp->dev_id, &info);
>   

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
diff mbox series

Patch

diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c
index e56d314e93b5..15ebcdfc1556 100644
--- a/app/test-bbdev/test_bbdev_perf.c
+++ b/app/test-bbdev/test_bbdev_perf.c
@@ -3722,6 +3722,7 @@  bler_pmd_lcore_ldpc_dec(void *arg)
 
 	TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST),
 			"BURST_SIZE should be <= %u", MAX_BURST);
+	TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0");
 
 	rte_bbdev_info_get(tp->dev_id, &info);
 
@@ -3856,6 +3857,7 @@  bler_pmd_lcore_turbo_dec(void *arg)
 
 	TEST_ASSERT_SUCCESS((burst_sz > MAX_BURST),
 			"BURST_SIZE should be <= %u", MAX_BURST);
+	TEST_ASSERT_SUCCESS((num_ops == 0), "NUM_OPS must be greater than 0");
 
 	rte_bbdev_info_get(tp->dev_id, &info);