diff mbox series

net/idpf: fix a compiler issue about virtchnl opcode

Message ID 20230309115219.278021-1-mingxia.liu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/idpf: fix a compiler issue about virtchnl opcode |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Liu, Mingxia March 9, 2023, 11:52 a.m. UTC 
  Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
with virtchnl2 or VIRTCHNL2.

Fixes: 78049b3dc7e6 ("net/idpf: add alarm to handle virtual channel message")

Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>
---
 drivers/net/idpf/idpf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit March 9, 2023, 12:10 p.m. UTC | #1 
On 3/9/2023 11:52 AM, Mingxia Liu wrote:
> Comparing an enum virtchnl_ops variable with VIRTCHNL2_OP_EVENT
> will cause a compiler issue, as VIRTCHNL2_OP_EVENT is not included
> in enum virtchnl_ops. And the PMD uses virtual msg opcodes prefixed
> with virtchnl2 or VIRTCHNL2.
> 
> Fixes: 78049b3dc7e6 ("net/idpf: add alarm to handle virtual channel message")
> 

Fixes: d633a4859c98 ("net/idpf: add alarm to handle virtual channel
message")

> Signed-off-by: Mingxia Liu <mingxia.liu@intel.com>

Reported-by: Raslan Darawsheh <rasland@nvidia.com>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>


Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index db58157ba3..46aec6ae37 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -1058,8 +1058,8 @@  idpf_handle_virtchnl_msg(struct idpf_adapter_ext *adapter_ex)
 	struct idpf_ctlq_msg ctlq_msg;
 	enum idpf_mbx_opc mbx_op;
 	struct idpf_vport *vport;
-	enum virtchnl_ops vc_op;
 	uint16_t pending = 1;
+	uint32_t vc_op;
 	int ret;
 
 	while (pending) {