diff mbox series

bus/platform: fix resource leak

Message ID 20230316081455.3352891-1-tduszynski@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series bus/platform: fix resource leak |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Tomasz Duszynski March 16, 2023, 8:14 a.m. UTC 
  On error function may return without releasing some
allocated resources which causes a memory leak. Fix it.

Coverity issue: 383660
Fixes: 17c839f74da3 ("bus: add platform bus")

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
 drivers/bus/platform/platform_params.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Thomas Monjalon March 16, 2023, 4:50 p.m. UTC | #1 
16/03/2023 09:14, Tomasz Duszynski:
> On error function may return without releasing some
> allocated resources which causes a memory leak. Fix it.
> 
> Coverity issue: 383660
> Fixes: 17c839f74da3 ("bus: add platform bus")
> 
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/platform/platform_params.c b/drivers/bus/platform/platform_params.c
index edc246b53e..0eb8eb56e7 100644
--- a/drivers/bus/platform/platform_params.c
+++ b/drivers/bus/platform/platform_params.c
@@ -63,8 +63,10 @@  platform_bus_dev_iterate(const void *start, const char *str,
 	}
 
 	find_device = platform_bus.bus.find_device;
-	if (find_device == NULL)
+	if (find_device == NULL) {
+		rte_kvargs_free(kvargs);
 		return NULL;
+	}
 
 	dev = platform_bus.bus.find_device(start, platform_dev_match, kvargs);
 	rte_kvargs_free(kvargs);