[2/2] bus/platform: do not allow adding existing device

Message ID 20230316094133.237641-2-tduszynski@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] bus/platform: fix resource names iteration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Tomasz Duszynski March 16, 2023, 9:41 a.m. UTC
  Do not allow adding the same device multiple times.

Coverity issue: 383663
Fixes: 17c839f74da3 ("bus: add platform bus")

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
---
 drivers/bus/platform/platform.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Thomas Monjalon March 16, 2023, 4:52 p.m. UTC | #1
16/03/2023 10:41, Tomasz Duszynski:
> Do not allow adding the same device multiple times.
> 
> Coverity issue: 383663
> Fixes: 17c839f74da3 ("bus: add platform bus")
> 
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>

Series applied, thanks.
  

Patch

diff --git a/drivers/bus/platform/platform.c b/drivers/bus/platform/platform.c
index a2faacdf18..d4b53f6fbc 100644
--- a/drivers/bus/platform/platform.c
+++ b/drivers/bus/platform/platform.c
@@ -103,6 +103,7 @@  dev_add(const char *dev_name)
 				rte_devargs_remove(pdev->device.devargs);
 
 			free(pdev);
+			return -EEXIST;
 		}
 	}