diff mbox series

bus/cdx: Remove ineffective code statement

Message ID 20230614102201.224495-1-abhijit.gangurde@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series bus/cdx: Remove ineffective code statement |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Abhijit Gangurde June 14, 2023, 10:22 a.m. UTC 
  ret = 0 statement is ineffective since it is overwritten in a loop.

Coverity issue: 385379
Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
---
 drivers/bus/cdx/cdx.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Gupta, Nipun June 15, 2023, 9:35 a.m. UTC | #1 
Acked-by: Nipun Gupta <nipun.gupta@amd.com>

On 6/14/2023 3:52 PM, Abhijit Gangurde wrote:
> ret = 0 statement is ineffective since it is overwritten in a loop.
> 
> Coverity issue: 385379
> Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> ---
>   drivers/bus/cdx/cdx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
> index 28bbf92ed5..9130c30515 100644
> --- a/drivers/bus/cdx/cdx.c
> +++ b/drivers/bus/cdx/cdx.c
> @@ -452,7 +452,6 @@ cdx_probe(void)
>   				dev->name);
>   			rte_errno = errno;
>   			failed++;
> -			ret = 0;
>   		}
>   	}
>
diff mbox series

Patch

diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 28bbf92ed5..9130c30515 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -452,7 +452,6 @@  cdx_probe(void)
 				dev->name);
 			rte_errno = errno;
 			failed++;
-			ret = 0;
 		}
 	}