[dpdk-dev,3/3] maintainers: add stable mailing list

Message ID 1480575999-14453-4-git-send-email-yuanhan.liu@linux.intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
checkpatch/checkpatch success coding style OK

Commit Message

Yuanhan Liu Dec. 1, 2016, 7:06 a.m. UTC
  Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
  

Comments

John McNamara Dec. 1, 2016, 3:18 p.m. UTC | #1
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Thursday, December 1, 2016 7:07 AM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Subject: [PATCH 3/3] maintainers: add stable mailing list
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
John McNamara Dec. 4, 2016, 4:36 p.m. UTC | #2
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Thursday, December 1, 2016 7:07 AM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Subject: [PATCH 3/3] maintainers: add stable mailing list
> 
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3df1754..076e86c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -35,6 +35,7 @@ F: scripts/test-build.sh  Stable Branches
>  ---------------
>  T: git://dpdk.org/dpdk-stable
> +M: stable@dpdk.org

I acked this previously but looking at it again I'm not 100% sure that stable@dpdk.org
should be the maintainer.

The glossary at the top of the file says:

    Descriptions of section entries:
        M: Maintainer's Full Name <address@domain>

So maybe the entry should have your name and also stable@dpdk.org on a separate line.
This would be clearer way of showing the stable release tree maintainer.

John
  
Yuanhan Liu Dec. 5, 2016, 4:36 a.m. UTC | #3
On Sun, Dec 04, 2016 at 04:36:36PM +0000, Mcnamara, John wrote:
> 
> 
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> > Sent: Thursday, December 1, 2016 7:07 AM
> > To: dev@dpdk.org
> > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Mcnamara, John
> > <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Subject: [PATCH 3/3] maintainers: add stable mailing list
> > 
> > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3df1754..076e86c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -35,6 +35,7 @@ F: scripts/test-build.sh  Stable Branches
> >  ---------------
> >  T: git://dpdk.org/dpdk-stable
> > +M: stable@dpdk.org
> 
> I acked this previously but looking at it again I'm not 100% sure that stable@dpdk.org
> should be the maintainer.
> 
> The glossary at the top of the file says:
> 
>     Descriptions of section entries:
>         M: Maintainer's Full Name <address@domain>
> 
> So maybe the entry should have your name and also stable@dpdk.org on a separate line.
> This would be clearer way of showing the stable release tree maintainer.

I actually just meant to add the stable mailing list addr (as the
subject says). Seems there are no such field for it?

	--yliu
  
Maxime Coquelin Dec. 5, 2016, 8:39 a.m. UTC | #4
On 12/05/2016 05:36 AM, Yuanhan Liu wrote:
> On Sun, Dec 04, 2016 at 04:36:36PM +0000, Mcnamara, John wrote:
>>
>>
>>> -----Original Message-----
>>> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
>>> Sent: Thursday, December 1, 2016 7:07 AM
>>> To: dev@dpdk.org
>>> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; Mcnamara, John
>>> <john.mcnamara@intel.com>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
>>> Subject: [PATCH 3/3] maintainers: add stable mailing list
>>>
>>> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>>> ---
>>>  MAINTAINERS | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 3df1754..076e86c 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -35,6 +35,7 @@ F: scripts/test-build.sh  Stable Branches
>>>  ---------------
>>>  T: git://dpdk.org/dpdk-stable
>>> +M: stable@dpdk.org
>>
>> I acked this previously but looking at it again I'm not 100% sure that stable@dpdk.org
>> should be the maintainer.
>>
>> The glossary at the top of the file says:
>>
>>     Descriptions of section entries:
>>         M: Maintainer's Full Name <address@domain>
>>
>> So maybe the entry should have your name and also stable@dpdk.org on a separate line.
>> This would be clearer way of showing the stable release tree maintainer.
>
> I actually just meant to add the stable mailing list addr (as the
> subject says). Seems there are no such field for it?
"L: stable@dpdk.org" ?

This is how MLs are added in Kernel's MAINTAINER file.

Cheers,
Maxime

>
> 	--yliu
>
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 3df1754..076e86c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -35,6 +35,7 @@  F: scripts/test-build.sh
 Stable Branches
 ---------------
 T: git://dpdk.org/dpdk-stable
+M: stable@dpdk.org
 
 Security Issues
 ---------------