diff mbox

[dpdk-dev,v2,28/32] net/i40e: return correct vsi_id

Message ID 1481081535-37448-29-git-send-email-wenzhuo.lu@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
checkpatch/checkpatch success coding style OK

Commit Message

Wenzhuo Lu Dec. 7, 2016, 3:32 a.m. UTC 
  PF host didn't return correct VSI id to VF.
This change fix it.

Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
 drivers/net/i40e/i40e_pf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ferruh Yigit Dec. 7, 2016, 3:16 p.m. UTC | #1 
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> PF host didn't return correct VSI id to VF.
> This change fix it.

This looks like a fix for current code,
can you please update commit title and log to reflect the fix?

> 
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> ---
>  drivers/net/i40e/i40e_pf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
> index 0f582ed..8319c2c 100644
> --- a/drivers/net/i40e/i40e_pf.c
> +++ b/drivers/net/i40e/i40e_pf.c
> @@ -351,8 +351,7 @@
>  
>  	/* Change below setting if PF host can support more VSIs for VF */
>  	vf_res->vsi_res[0].vsi_type = I40E_VSI_SRIOV;
> -	/* As assume Vf only has single VSI now, always return 0 */
> -	vf_res->vsi_res[0].vsi_id = 0;
> +	vf_res->vsi_res[0].vsi_id = vf->vsi->vsi_id;
>  	vf_res->vsi_res[0].num_queue_pairs = vf->vsi->nb_qps;
>  	ether_addr_copy(&vf->mac_addr,
>  		(struct ether_addr *)vf_res->vsi_res[0].default_mac_addr);
>
Chen, Jing D Dec. 7, 2016, 3:34 p.m. UTC | #2 
Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 11:16 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Chen, Jing D <jing.d.chen@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 28/32] net/i40e: return correct vsi_id
> 
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > PF host didn't return correct VSI id to VF.
> > This change fix it.
> 
> This looks like a fix for current code,
> can you please update commit title and log to reflect the fix?
> 

This is similar patch to support Linux VF client. DPDK VF client needn't
Vsi ID.

> >
> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
> > ---
> >  drivers/net/i40e/i40e_pf.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
> > index 0f582ed..8319c2c 100644
> > --- a/drivers/net/i40e/i40e_pf.c
> > +++ b/drivers/net/i40e/i40e_pf.c
> > @@ -351,8 +351,7 @@
> >
> >  	/* Change below setting if PF host can support more VSIs for VF */
> >  	vf_res->vsi_res[0].vsi_type = I40E_VSI_SRIOV;
> > -	/* As assume Vf only has single VSI now, always return 0 */
> > -	vf_res->vsi_res[0].vsi_id = 0;
> > +	vf_res->vsi_res[0].vsi_id = vf->vsi->vsi_id;
> >  	vf_res->vsi_res[0].num_queue_pairs = vf->vsi->nb_qps;
> >  	ether_addr_copy(&vf->mac_addr,
> >  		(struct ether_addr *)vf_res->vsi_res[0].default_mac_addr);
> >
diff mbox

Patch

diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c
index 0f582ed..8319c2c 100644
--- a/drivers/net/i40e/i40e_pf.c
+++ b/drivers/net/i40e/i40e_pf.c
@@ -351,8 +351,7 @@ 
 
 	/* Change below setting if PF host can support more VSIs for VF */
 	vf_res->vsi_res[0].vsi_type = I40E_VSI_SRIOV;
-	/* As assume Vf only has single VSI now, always return 0 */
-	vf_res->vsi_res[0].vsi_id = 0;
+	vf_res->vsi_res[0].vsi_id = vf->vsi->vsi_id;
 	vf_res->vsi_res[0].num_queue_pairs = vf->vsi->nb_qps;
 	ether_addr_copy(&vf->mac_addr,
 		(struct ether_addr *)vf_res->vsi_res[0].default_mac_addr);