[dpdk-dev,v2] doc: fix required tools list layout

Message ID 48da34687fbcd3c2dc2b16e5630c0f1c1b4a904f.1482175720.git.baruch@tkos.co.il (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Baruch Siach Dec. 19, 2016, 7:28 p.m. UTC
  The Python requirement should appear in the bullet list.

Also, indent the x32 note, since it is related to the previous bullet.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2: Indent also the note paragraph (John)
---
 doc/guides/linux_gsg/sys_reqs.rst | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
  

Comments

John McNamara Dec. 20, 2016, 9:42 a.m. UTC | #1
> -----Original Message-----
> From: Baruch Siach [mailto:baruch@tkos.co.il]
> Sent: Monday, December 19, 2016 7:29 PM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Baruch Siach
> <baruch@tkos.co.il>
> Subject: [PATCH v2] doc: fix required tools list layout
> 
> The Python requirement should appear in the bullet list.
> 
> Also, indent the x32 note, since it is related to the previous bullet.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Acked-by: John McNamara <john.mcnamara@intel.com>
  
Thomas Monjalon Dec. 20, 2016, 10:26 a.m. UTC | #2
> > The Python requirement should appear in the bullet list.
> > 
> > Also, indent the x32 note, since it is related to the previous bullet.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks
  
John McNamara Dec. 20, 2016, 10:35 a.m. UTC | #3
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, December 20, 2016 10:27 AM
> To: Baruch Siach <baruch@tkos.co.il>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] doc: fix required tools list layout
> 
> > > The Python requirement should appear in the bullet list.
> > >
> > > Also, indent the x32 note, since it is related to the previous bullet.
> > >
> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
> 
> Applied, thanks

Thanks. 

I'll rebase my other patch that touches this file:

    http://dpdk.org/dev/patchwork/patch/18152/

John
  

Patch

diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
index 3d743421595a..76d82e6eef75 100644
--- a/doc/guides/linux_gsg/sys_reqs.rst
+++ b/doc/guides/linux_gsg/sys_reqs.rst
@@ -79,14 +79,12 @@  Compilation of the DPDK
 
     * glibc.ppc64, libgcc.ppc64, libstdc++.ppc64 and glibc-devel.ppc64 for IBM ppc_64;
 
-.. note::
-
-    x86_x32 ABI is currently supported with distribution packages only on Ubuntu
-    higher than 13.10 or recent Debian distribution. The only supported  compiler is gcc 4.9+.
+    .. note::
 
-.. note::
+       x86_x32 ABI is currently supported with distribution packages only on Ubuntu
+       higher than 13.10 or recent Debian distribution. The only supported  compiler is gcc 4.9+.
 
-    Python, version 2.6 or 2.7, to use various helper scripts included in the DPDK package.
+*   Python, version 2.6 or 2.7, to use various helper scripts included in the DPDK package.
 
 
 **Optional Tools:**