diff mbox

[dpdk-dev,v2] doc: introduce PVP reference benchmark

Message ID 15125480.nLCo42mjm8@xps13 (mailing list archive)
State Not Applicable, archived
Headers

Checks

Context Check Description
ci/Intel compilation success Compilation OK

Commit Message

Thomas Monjalon Dec. 20, 2016, 10:03 a.m. UTC 
  > > >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > >
> > > There is one trailing whitespace warning but apart from that:
> > >
> > > Acked-by: John McNamara <john.mcnamara@intel.com>
> > 
> > Thanks John,
> > 
> > Do you want me to send a v3, fixing the trailing whitespace & collecting
> > the acks?
> 
> No need (unless the tree maintainer says otherwise).
> It was one trailing whitespace. Just something to look out for in future. 

Removed when applying.
Fixed some heading issues also:



Thanks

Comments

Maxime Coquelin Dec. 20, 2016, 2:54 p.m. UTC | #1 
On 12/20/2016 11:03 AM, Thomas Monjalon wrote:
>>>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>>
>>>> There is one trailing whitespace warning but apart from that:
>>>>
>>>> Acked-by: John McNamara <john.mcnamara@intel.com>
>>>
>>> Thanks John,
>>>
>>> Do you want me to send a v3, fixing the trailing whitespace & collecting
>>> the acks?
>>
>> No need (unless the tree maintainer says otherwise).
>> It was one trailing whitespace. Just something to look out for in future.
>
> Removed when applying.
> Fixed some heading issues also:
>
> --- a/doc/guides/howto/pvp_reference_benchmark.rst
> +++ b/doc/guides/howto/pvp_reference_benchmark.rst
> @@ -160,7 +160,7 @@ Testpmd launch
>            --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
>            --nb-cores=4 --forward-mode=io
>
> -With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
> +   With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
>
>  #. In testpmd interactive mode, set the portlist to obtain the correct port
>     chaining:
> @@ -176,7 +176,8 @@ VM launch
>
>  The VM may be launched either by calling QEMU directly, or by using libvirt.
>
> -#. Qemu way:
> +Qemu way
> +^^^^^^^^
>
>  Launch QEMU with two Virtio-net devices paired to the vhost-user sockets
>  created by testpmd. Below example uses default Virtio-net options, but options
> @@ -210,7 +211,8 @@ where isolated CPUs 6 and 7 will be used as lcores for Virtio PMDs:
>        export PYTHONPATH=$PYTHONPATH:<QEMU path>/scripts/qmp
>        ./qmp-vcpu-pin -s /tmp/qmp.socket 1 6 7
>
> -#. Libvirt way:
> +Libvirt way
> +^^^^^^^^^^^
>
>  Some initial steps are required for libvirt to be able to connect to testpmd's
>  sockets.

Thanks Thomas for handling these fixes.

Maxime
diff mbox

Patch

--- a/doc/guides/howto/pvp_reference_benchmark.rst
+++ b/doc/guides/howto/pvp_reference_benchmark.rst
@@ -160,7 +160,7 @@  Testpmd launch
           --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
           --nb-cores=4 --forward-mode=io
 
-With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
+   With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
 
 #. In testpmd interactive mode, set the portlist to obtain the correct port
    chaining:
@@ -176,7 +176,8 @@  VM launch
 
 The VM may be launched either by calling QEMU directly, or by using libvirt.
 
-#. Qemu way:
+Qemu way
+^^^^^^^^
 
 Launch QEMU with two Virtio-net devices paired to the vhost-user sockets
 created by testpmd. Below example uses default Virtio-net options, but options
@@ -210,7 +211,8 @@  where isolated CPUs 6 and 7 will be used as lcores for Virtio PMDs:
       export PYTHONPATH=$PYTHONPATH:<QEMU path>/scripts/qmp
       ./qmp-vcpu-pin -s /tmp/qmp.socket 1 6 7
 
-#. Libvirt way:
+Libvirt way
+^^^^^^^^^^^
 
 Some initial steps are required for libvirt to be able to connect to testpmd's
 sockets.