diff mbox

[dpdk-dev,v2] net/ixgbe/base: clear redundant macro define

Message ID 1482285839-42805-1-git-send-email-yao.chenghu@zte.com.cn (mailing list archive)
State Rejected, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Chenghu Yao Dec. 21, 2016, 2:03 a.m. UTC 
  In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and
IXGBE_VF_GET_QUEUES appear two times with the same name, value,
and notes.

Version 2.0 VF requests can inherit the two macro defines
in previous version 1.0 and 1.1. Otherwise, maybe cause confusion.

Signed-off-by: Chenghu Yao <yao.chenghu@zte.com.cn>
---
v2:
* eliminate commit warning
---
 drivers/net/ixgbe/base/ixgbe_mbx.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Wenzhuo Lu Feb. 3, 2017, 2:37 a.m. UTC | #1 
Hi Chenghu,


> -----Original Message-----
> From: Chenghu Yao [mailto:yao.chenghu@zte.com.cn]
> Sent: Wednesday, December 21, 2016 10:04 AM
> To: Lu, Wenzhuo; Zhang, Helin
> Cc: dev@dpdk.org; Chenghu Yao
> Subject: [PATCH v2] net/ixgbe/base: clear redundant macro define
> 
> In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and
> IXGBE_VF_GET_QUEUES appear two times with the same name, value, and
> notes.
> 
> Version 2.0 VF requests can inherit the two macro defines in previous version
> 1.0 and 1.1. Otherwise, maybe cause confusion.
As 1.x is for linux/freebsd, but 2.0 is for solaris, 2.0 doesn't leverage the messages from 1.x. For example, 0x0a has different meaning in 1.x and 2.0. So better letting it be.
Chenghu Yao Feb. 6, 2017, 10:38 a.m. UTC | #2 
> As 1.x is for linux/freebsd, but 2.0 is for solaris, 2.0 doesn't 
> leverage the messages from 1.x. For example, 0x0a has different 
> meaning in 1.x and 2.0. So better letting it be. 
> 

Ok, thanks for your reply.
diff mbox

Patch

diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h b/drivers/net/ixgbe/base/ixgbe_mbx.h
index 7556a81..483e9b3 100644
--- a/drivers/net/ixgbe/base/ixgbe_mbx.h
+++ b/drivers/net/ixgbe/base/ixgbe_mbx.h
@@ -128,8 +128,6 @@  enum ixgbe_pfvf_api_rev {
 #define IXGBE_PF_CONTROL_MSG		0x0100 /* PF control message */
 
 /* mailbox API, version 2.0 VF requests */
-#define IXGBE_VF_API_NEGOTIATE		0x08 /* negotiate API version */
-#define IXGBE_VF_GET_QUEUES		0x09 /* get queue configuration */
 #define IXGBE_VF_ENABLE_MACADDR		0x0A /* enable MAC address */
 #define IXGBE_VF_DISABLE_MACADDR	0x0B /* disable MAC address */
 #define IXGBE_VF_GET_MACADDRS		0x0C /* get all configured MAC addrs */