[dpdk-dev,6/8] qat: don't refer to eth_dev->pci_dev

Message ID 20170107181756.1944-7-sthemmin@microsoft.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Stephen Hemminger Jan. 7, 2017, 6:17 p.m. UTC
  Later patches remove pci_dev from the ethernet device structure.
Fix the quick assist code to just use it's own name when forming zone name.

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/crypto/qat/qat_qp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Jan Blunck Jan. 10, 2017, 12:15 p.m. UTC | #1
On Sat, Jan 7, 2017 at 7:17 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> Later patches remove pci_dev from the ethernet device structure.
> Fix the quick assist code to just use it's own name when forming zone name.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
>  drivers/crypto/qat/qat_qp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c
> index 2e7188bd..fe76e04a 100644
> --- a/drivers/crypto/qat/qat_qp.c
> +++ b/drivers/crypto/qat/qat_qp.c
> @@ -299,9 +299,9 @@ qat_queue_create(struct rte_cryptodev *dev, struct qat_queue *queue,
>         /*
>          * Allocate a memzone for the queue - create a unique name.
>          */
> -       snprintf(queue->memz_name, sizeof(queue->memz_name), "%s_%s_%d_%d_%d",
> -               dev->driver->pci_drv.driver.name, "qp_mem", dev->data->dev_id,
> -               queue->hw_bundle_number, queue->hw_queue_number);
> +       snprintf(queue->memz_name, sizeof(queue->memz_name),
> +                "qat_qp_mem_%d_%u_%u", dev->data->dev_id,

This driver is called 'crypto_qat'.

> +                queue->hw_bundle_number, queue->hw_queue_number);
>         qp_mz = queue_dma_zone_reserve(queue->memz_name, queue_size_bytes,
>                         socket_id);
>         if (qp_mz == NULL) {
> --
> 2.11.0
>
  

Patch

diff --git a/drivers/crypto/qat/qat_qp.c b/drivers/crypto/qat/qat_qp.c
index 2e7188bd..fe76e04a 100644
--- a/drivers/crypto/qat/qat_qp.c
+++ b/drivers/crypto/qat/qat_qp.c
@@ -299,9 +299,9 @@  qat_queue_create(struct rte_cryptodev *dev, struct qat_queue *queue,
 	/*
 	 * Allocate a memzone for the queue - create a unique name.
 	 */
-	snprintf(queue->memz_name, sizeof(queue->memz_name), "%s_%s_%d_%d_%d",
-		dev->driver->pci_drv.driver.name, "qp_mem", dev->data->dev_id,
-		queue->hw_bundle_number, queue->hw_queue_number);
+	snprintf(queue->memz_name, sizeof(queue->memz_name),
+		 "qat_qp_mem_%d_%u_%u", dev->data->dev_id,
+		 queue->hw_bundle_number, queue->hw_queue_number);
 	qp_mz = queue_dma_zone_reserve(queue->memz_name, queue_size_bytes,
 			socket_id);
 	if (qp_mz == NULL) {