[dpdk-dev,v4,1/6] lib: distributor performance enhancements

  On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote:
> Now sends bursts of up to 8 mbufs to each worker, and tracks
> the in-flight flow-ids (atomic scheduling)
> 
> New file with a new api, similar to the old API except with _burst
> at the end of the function names
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  lib/librte_distributor/Makefile                    |   2 +
>  lib/librte_distributor/rte_distributor.c           |  72 +--
>  lib/librte_distributor/rte_distributor_burst.c     | 558 +++++++++++++++++++++
>  lib/librte_distributor/rte_distributor_burst.h     | 255 ++++++++++
>  lib/librte_distributor/rte_distributor_priv.h      | 189 +++++++
>  lib/librte_distributor/rte_distributor_version.map |   9 +
>  6 files changed, 1014 insertions(+), 71 deletions(-)
>  create mode 100644 lib/librte_distributor/rte_distributor_burst.c
>  create mode 100644 lib/librte_distributor/rte_distributor_burst.h
>  create mode 100644 lib/librte_distributor/rte_distributor_priv.h
> 
Run a documentation sanity check after this patch throws up a few
warnings:

rte_distributor_return_pkt_burst(struct rte_distributor_burst *d,
unsigned int worker_id, struct rte_mbuf **oldpkt, int num) are not
documented:
+  parameter 'oldpkt'
+  parameter 'num'
+/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
warning: Found unknown command `\in_flight_bitmask'
+/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
warning: Found unknown command `\rte_distributor_process'

Regards,
/Bruce
  

On 13/1/2017 3:19 PM, Bruce Richardson wrote:
> On Mon, Jan 09, 2017 at 07:50:43AM +0000, David Hunt wrote:
>> Now sends bursts of up to 8 mbufs to each worker, and tracks
>> the in-flight flow-ids (atomic scheduling)
>>
>> New file with a new api, similar to the old API except with _burst
>> at the end of the function names
>>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>>   lib/librte_distributor/Makefile                    |   2 +
>>   lib/librte_distributor/rte_distributor.c           |  72 +--
>>   lib/librte_distributor/rte_distributor_burst.c     | 558 +++++++++++++++++++++
>>   lib/librte_distributor/rte_distributor_burst.h     | 255 ++++++++++
>>   lib/librte_distributor/rte_distributor_priv.h      | 189 +++++++
>>   lib/librte_distributor/rte_distributor_version.map |   9 +
>>   6 files changed, 1014 insertions(+), 71 deletions(-)
>>   create mode 100644 lib/librte_distributor/rte_distributor_burst.c
>>   create mode 100644 lib/librte_distributor/rte_distributor_burst.h
>>   create mode 100644 lib/librte_distributor/rte_distributor_priv.h
>>
> Run a documentation sanity check after this patch throws up a few
> warnings:
>
> --- /dev/null   2017-01-10 10:26:01.206201474 +0000
> +++ /tmp/doc-check/doc.txt      2017-01-13 15:19:50.717102848 +0000
> @@ -0,0 +1,6 @@
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:187:
> warning: argument 'mbuf' of command @param is not found in the argument
> list of rte_distributor_return_pkt_burst(struct rte_distributor_burst
> *d, unsigned int worker_id, struct rte_mbuf **oldpkt, int num)
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_burst.h:199:
> warning: The following parameters of
> rte_distributor_return_pkt_burst(struct rte_distributor_burst *d,
> unsigned int worker_id, struct rte_mbuf **oldpkt, int num) are not
> documented:
> +  parameter 'oldpkt'
> +  parameter 'num'
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
> warning: Found unknown command `\in_flight_bitmask'
> +/home/bruce/dpdk-clean/lib/librte_distributor/rte_distributor_priv.h:73:
> warning: Found unknown command `\rte_distributor_process'
>
> Regards,
> /Bruce

Will be cleaned up in next revsion.

Thanks,
Dave.