diff mbox

[dpdk-dev] net/cxgbe: add parenthesis on bitwise operation

Message ID 1484509837-15924-1-git-send-email-emmanuel.roullit@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Emmanuel Roullit Jan. 15, 2017, 7:50 p.m. UTC 
  clang reports the following error:
error: logical not is only applied to the left hand side of this bitwise
operator. [-Werror,-Wlogical-not-parentheses]

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 drivers/net/cxgbe/cxgbe_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Jan. 16, 2017, 12:58 p.m. UTC | #1 
On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
> clang reports the following error:
> error: logical not is only applied to the left hand side of this bitwise
> operator. [-Werror,-Wlogical-not-parentheses]
> 
> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit Jan. 16, 2017, 1:17 p.m. UTC | #2 
On 1/16/2017 12:58 PM, Ferruh Yigit wrote:
> On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
>> clang reports the following error:
>> error: logical not is only applied to the left hand side of this bitwise
>> operator. [-Werror,-Wlogical-not-parentheses]
>>
>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")

Applied to dpdk-next-net/master, thanks.
Ferruh Yigit Jan. 16, 2017, 1:18 p.m. UTC | #3 
On 1/16/2017 1:17 PM, Ferruh Yigit wrote:
> On 1/16/2017 12:58 PM, Ferruh Yigit wrote:
>> On 1/15/2017 7:50 PM, Emmanuel Roullit wrote:
>>> clang reports the following error:
>>> error: logical not is only applied to the left hand side of this bitwise
>>> operator. [-Werror,-Wlogical-not-parentheses]
>>>
>>> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support")
> 
> Applied to dpdk-next-net/master, thanks.

CC: stable@dpdk.org
diff mbox

Patch

diff --git a/drivers/net/cxgbe/cxgbe_main.c b/drivers/net/cxgbe/cxgbe_main.c
index 7ccf434..541fc40 100644
--- a/drivers/net/cxgbe/cxgbe_main.c
+++ b/drivers/net/cxgbe/cxgbe_main.c
@@ -959,7 +959,7 @@  int setup_rss(struct port_info *pi)
 	dev_debug(adapter, "%s:  pi->rss_size = %u; pi->n_rx_qsets = %u\n",
 		  __func__, pi->rss_size, pi->n_rx_qsets);
 
-	if (!pi->flags & PORT_RSS_DONE) {
+	if (!(pi->flags & PORT_RSS_DONE)) {
 		if (adapter->flags & FULL_INIT_DONE) {
 			/* Fill default values with equal distribution */
 			for (j = 0; j < pi->rss_size; j++)