diff mbox

[dpdk-dev] ethdev: remove useless pointer initialization

Message ID 20170124202835.1271-1-emmanuel.roullit@gmail.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Emmanuel Roullit Jan. 24, 2017, 8:28 p.m. UTC 
  Found with clang static analysis:
lib/librte_ether/rte_ethdev.c:2467:22:
warning: Value stored to 'dev' during its initialization is never read
struct rte_eth_dev *dev = &rte_eth_devices[port_id];
                    ^~~   ~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port")

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 lib/librte_ether/rte_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Jan. 30, 2017, 9:40 a.m. UTC | #1 
2017-01-24 21:28, Emmanuel Roullit:
> Found with clang static analysis:
> lib/librte_ether/rte_ethdev.c:2467:22:
> warning: Value stored to 'dev' during its initialization is never read
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
>                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port")

Wrong commit reference.
Fixes: 88ac4396ad29 ("ethdev: add VMDq support")

> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Applied, thanks
diff mbox

Patch

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index 61f44e218..d7f78c23a 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -2364,7 +2364,7 @@  rte_eth_mirror_rule_set(uint8_t port_id,
 			struct rte_eth_mirror_conf *mirror_conf,
 			uint8_t rule_id, uint8_t on)
 {
-	struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+	struct rte_eth_dev *dev;
 
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
 	if (mirror_conf->rule_type == 0) {
@@ -2400,7 +2400,7 @@  rte_eth_mirror_rule_set(uint8_t port_id,
 int
 rte_eth_mirror_rule_reset(uint8_t port_id, uint8_t rule_id)
 {
-	struct rte_eth_dev *dev = &rte_eth_devices[port_id];
+	struct rte_eth_dev *dev;
 
 	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);