diff mbox

[dpdk-dev] vhost: remove unneeded variable assignment

Message ID 20170124203129.2850-1-emmanuel.roullit@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Yuanhan Liu
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel compilation success Compilation OK

Commit Message

Emmanuel Roullit Jan. 24, 2017, 8:31 p.m. UTC 
  Found with clang static analysis:
lib/librte_vhost/vhost_user.c:996:3: warning:
Value stored to 'ret' is never read
        ret = vhost_user_get_vring_base(dev, &msg.payload.state);
        ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 73c8f9f69c6c ("vhost: introduce reply ack feature")

Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>
---
 lib/librte_vhost/vhost_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yuanhan Liu Jan. 30, 2017, 12:47 p.m. UTC | #1 
On Tue, Jan 24, 2017 at 09:31:29PM +0100, Emmanuel Roullit wrote:
> Found with clang static analysis:
> lib/librte_vhost/vhost_user.c:996:3: warning:
> Value stored to 'ret' is never read
>         ret = vhost_user_get_vring_base(dev, &msg.payload.state);
>         ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 73c8f9f69c6c ("vhost: introduce reply ack feature")

Again, you were referencing the bad commit. For this case, I'd like to
remove such fixline, as this patch doesn't really "fix" anything. But
since you made it, I could apply it.

So applied to dpdk-next-virtio.

	--yliu
diff mbox

Patch

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 7343a00a1..3391d5ea5 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -995,7 +995,7 @@  vhost_user_msg_handler(int vid, int fd)
 		break;
 
 	case VHOST_USER_GET_VRING_BASE:
-		ret = vhost_user_get_vring_base(dev, &msg.payload.state);
+		vhost_user_get_vring_base(dev, &msg.payload.state);
 		msg.size = sizeof(msg.payload.state);
 		send_vhost_message(fd, &msg);
 		break;